netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] seg6: Delete invalid code
@ 2022-09-29  9:56 Hongbin Wang
  2022-09-30  1:25 ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: Hongbin Wang @ 2022-09-29  9:56 UTC (permalink / raw)
  To: davem; +Cc: yoshfuji, dsahern, edumazet, kuba, pabeni, netdev, linux-kernel,
	bpf

void function return statements are not generally useful

Signed-off-by: Hongbin Wang <wh_bin@126.com>
---
 net/ipv6/seg6_local.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/net/ipv6/seg6_local.c b/net/ipv6/seg6_local.c
index b7de5e46fdd8..a799ac83df3a 100644
--- a/net/ipv6/seg6_local.c
+++ b/net/ipv6/seg6_local.c
@@ -1830,8 +1830,6 @@ static void seg6_local_destroy_state(struct lwtunnel_state *lwt)
 	seg6_local_lwtunnel_destroy_state(slwt);
 
 	destroy_attrs(slwt);
-
-	return;
 }
 
 static int seg6_local_fill_encap(struct sk_buff *skb,
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] seg6: Delete invalid code
  2022-09-29  9:56 [PATCH] seg6: Delete invalid code Hongbin Wang
@ 2022-09-30  1:25 ` Jakub Kicinski
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2022-09-30  1:25 UTC (permalink / raw)
  To: Hongbin Wang
  Cc: davem, yoshfuji, dsahern, edumazet, pabeni, netdev, linux-kernel,
	bpf

On Thu, 29 Sep 2022 05:56:49 -0400 Hongbin Wang wrote:
> void function return statements are not generally useful

I don't think this is worth applying, sorry.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-30  1:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-29  9:56 [PATCH] seg6: Delete invalid code Hongbin Wang
2022-09-30  1:25 ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).