From: Jakub Kicinski <kuba@kernel.org>
To: Kevin Mitchell <kevmitch@arista.com>
Cc: Antoine Tenart <atenart@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: new warning caused by ("net-sysfs: update the queue counts in the unregistration path")
Date: Thu, 29 Sep 2022 19:11:37 -0700 [thread overview]
Message-ID: <20220929191137.7393bee4@kernel.org> (raw)
In-Reply-To: <YzTWwf/FyzBKGaww@chmeee>
On Wed, 28 Sep 2022 16:20:33 -0700 Kevin Mitchell wrote:
> > As you said and looking around queue 0 is somewhat special and used as a
> > fallback. My suggestion would be to 1) check if the above race is
> > expected 2) if yes, a possible solution would be not to warn when
> > real_num_tx_queues == 0 as in such cases selecting queue 0 would be the
> > expected fallback (and you might want to check places like [1]).
>
> Yes this is exactly where this is happening and that sounds like a good idea to
> me. As far as I can tell, the message is completely innocuous. If there really
> are no cases where it is useful to have this warning for real_num_tx_queues ==
> 0, I could submit a patch to not emit it in that case.
SGTM, FWIW.
prev parent reply other threads:[~2022-09-30 2:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 1:27 new warning caused by ("net-sysfs: update the queue counts in the unregistration path") Kevin Mitchell
2022-09-28 9:46 ` Antoine Tenart
2022-09-28 23:20 ` Kevin Mitchell
2022-09-30 2:11 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929191137.7393bee4@kernel.org \
--to=kuba@kernel.org \
--cc=atenart@kernel.org \
--cc=kevmitch@arista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).