From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0673C433FE for ; Fri, 30 Sep 2022 15:44:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231548AbiI3Pom (ORCPT ); Fri, 30 Sep 2022 11:44:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231473AbiI3Pok (ORCPT ); Fri, 30 Sep 2022 11:44:40 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B309FBCB4; Fri, 30 Sep 2022 08:44:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 66503B82931; Fri, 30 Sep 2022 15:44:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E05AC433C1; Fri, 30 Sep 2022 15:44:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664552673; bh=AcLbAv/XJtLL0m7WOesoWHUm/GUkwsx0vRv9GeXUrds=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=r1CuoAerkt/1p1c8v/KtmZOSs+FKGMcS0z4TxJJhamcAU/tlJn8kUPd4TKB5KzPT0 x+aAlU2Fdwv6Mk1ccEu676FI+tiFs4nmLo3txQnqiBPppmQ58ahUCFIoPB5HWxmtDj sazegYrm/UNkjJZf7/plKO3tB5JBbDmz6d0zHUbThnjtLEjyzfRsZ+Oziig6f6tEfg gwiusA8lTHX0nEwX7l1veUcN926HVZpPbf8v4YlS2rUsfZz5I0s8POp91mELpkC33E 24gvnTq0lq1wkPufmxdSPSV+2ICmDInrIS0lv+9vPYOFQLuZS70sp7QZRmWW5VcNgJ PR1EzDKNvfGwQ== Date: Fri, 30 Sep 2022 08:44:31 -0700 From: Jakub Kicinski To: Joe Perches Cc: Jiasheng Jiang , pabeni@redhat.com, davem@davemloft.net, tchornyi@marvell.com, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Volodymyr Mytnyk , Greg Kroah-Hartman Subject: Re: [PATCH] net: prestera: acl: Add check for kmemdup Message-ID: <20220930084431.508ce665@kernel.org> In-Reply-To: References: <20220930050317.32706-1-jiasheng@iscas.ac.cn> <20220930072952.2d337b3a@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 30 Sep 2022 08:20:47 -0700 Joe Perches wrote: > IMO: If Volodymyr wants to be a maintainer here, he should put > his email as an entry in the MAINTAINERS file for the subsystem. It's about Fixes tags, unfortunately having everyone of note listed in MAINTAINERS is pretty much impossible. Even tho we are trying. > > > Maybe there is a problem of the script that misses one. > > I don't think so. Maybe you have more evidence... I'll CC you when I tell people to CC authors of patches under Fixes going forward, I don't have a list going back. > > > Anyway, I have already submitted the same patch and added > > > "vmytnyk@marvell.com" this time. > > > > Ha! So you do indeed use it in a way I wasn't expecting :S > > Thanks for the explanation. > > > > Joe, would you be okay to add a "big fat warning" to get_maintainer > > when people try to use the -f flag? > > No, not really. -f isn't required when the file is in git anyway. Ah. Yeah. I'd make it error out when run on a source file without -f :S > > Maybe we can also change the message > > that's displayed when the script is run without arguments to not > > mention -f? > > I think that's a poor idea as frequently the script isn't used > on patches but simply to identify the maintainers of a particular > file or subsystem. Identify the maintainers and report a bug, or something else? As a maintainer I can tell you that I don't see bug reports as often as I see trivial patches from noobs which miss CCs. And I personally don't think I ever used get_maintainer on anything else than a patch. > > We're getting quite a few fixes which don't CC author, I'm guessing > > Jiasheng's approach may be a common one. > > There's no great way to identify "author" or "original submitter" > and frequently the "original submitter" isn't a maintainer anyway. Confusing sentence. We want for people who s-o-b'd the commit under Fixes to be CCed.