From: Jakub Kicinski <kuba@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Jiasheng Jiang <jiasheng@iscas.ac.cn>,
pabeni@redhat.com, davem@davemloft.net, tchornyi@marvell.com,
edumazet@google.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Volodymyr Mytnyk <vmytnyk@marvell.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] net: prestera: acl: Add check for kmemdup
Date: Fri, 30 Sep 2022 09:58:28 -0700 [thread overview]
Message-ID: <20220930095828.771d1ad5@kernel.org> (raw)
In-Reply-To: <76e4463b9ea5946e7af045363d888b966ba5e209.camel@perches.com>
On Fri, 30 Sep 2022 09:43:54 -0700 Joe Perches wrote:
> > > There's no great way to identify "author" or "original submitter"
> > > and frequently the "original submitter" isn't a maintainer anyway.
> >
> > Confusing sentence. We want for people who s-o-b'd the commit under
> > Fixes to be CCed.
>
> If a file or a file modified by a patch is listed in the MAINTAINERS,
> git history isn't used unless --git is specified.
>
> For a patch, maybe the author and other SOBs of a commit specified
> by a "Fixes:" line SHA-1 in the commit message could be added automatically.
Yes, git history isn't used, but the Fixes tag are consulted already
AFAICT. We just need to steer people towards running the script on
the patch.
$ git format-patch net/main~..net/main -o /tmp/
/tmp/0001-eth-alx-take-rtnl_lock-on-resume.patch
$ grep Fixes /tmp/0001-eth-alx-take-rtnl_lock-on-resume.patch
Fixes: 4a5fe57e7751 ("alx: use fine-grained locking instead of RTNL")
$ git show 4a5fe57e7751 --pretty='%an <%ae>' --no-patch
Johannes Berg <johannes@sipsolutions.net>
$ ./scripts/get_maintainer.pl /tmp/0001-eth-alx-take-rtnl_lock-on-resume.patch | grep blame
"David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING DRIVERS,commit_signer:2/4=50%,blamed_fixes:1/1=100%)
Johannes Berg <johannes@sipsolutions.net> (blamed_fixes:1/1=100%)
next prev parent reply other threads:[~2022-09-30 16:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 5:03 Re: [PATCH] net: prestera: acl: Add check for kmemdup Jiasheng Jiang
2022-09-30 14:29 ` Jakub Kicinski
2022-09-30 15:20 ` Joe Perches
2022-09-30 15:44 ` Jakub Kicinski
2022-09-30 16:43 ` Joe Perches
2022-09-30 16:58 ` Jakub Kicinski [this message]
2022-09-30 18:28 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2022-09-30 4:48 Jiasheng Jiang
2022-09-30 9:20 ` Taras Chornyi
2022-10-03 11:40 ` patchwork-bot+netdevbpf
2022-09-28 9:20 Jiasheng Jiang
2022-09-29 16:15 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220930095828.771d1ad5@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiasheng@iscas.ac.cn \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tchornyi@marvell.com \
--cc=vmytnyk@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).