From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC3CEC433FE for ; Fri, 30 Sep 2022 16:02:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231866AbiI3QC3 (ORCPT ); Fri, 30 Sep 2022 12:02:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231928AbiI3QCE (ORCPT ); Fri, 30 Sep 2022 12:02:04 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF00B1A9A76 for ; Fri, 30 Sep 2022 09:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664553717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dSaLrZl2pRqIhF9cHurGbopli303/71ZQUFNstj/m0M=; b=RJjIFvr0cXbyYfVHV4U/QORLQkyq91apWNQrACLlvQynycAKPksqaCAi1BeKzYRFiZy/y5 FttUbvVIaTZRtciyPjoZS2IgTHmiTieO1Fv9NRYfC0DwX1H0L1gaMXZrO8YeVlj1UcXdAl SfMa3fSo8GCc/uQxaHanRvYmldwwKxw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-284-aCe8fVFpNUWClUhq7hzJKg-1; Fri, 30 Sep 2022 12:01:55 -0400 X-MC-Unique: aCe8fVFpNUWClUhq7hzJKg-1 Received: by mail-wr1-f72.google.com with SMTP id r22-20020adfa156000000b0022cc3018fbaso1718008wrr.2 for ; Fri, 30 Sep 2022 09:01:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date; bh=dSaLrZl2pRqIhF9cHurGbopli303/71ZQUFNstj/m0M=; b=l1mGXNKV5511AqeAcMIOa5XCVi6ovfjh/KP5c6rkeX6hCX0imm20bM0vRZrSvnStLC xCheNXIGM63M96oCdAk789bFuT134pY+t3T05dO9+h3gR6vgFlTT9mcHfgiYiMsv5Vlv 85k+aINTSSCekDzg6z1jL0AmdRi+q9KOO0HTgPDjboSmAYclOwjT11o+UVOZu1rIOOu6 iEWMa1D9PLVWfnvfglo1e7k4iFdYdpP013OMlOiSmahLPUP9CV2e/v/SPRsldhL8r27s uMvtwsXPQwRKTd9OhrLlYAy+THTH323q+IGQOh9zLRqLDYW5Ntp24WbMLbO7f7Kq12Cz eu/g== X-Gm-Message-State: ACrzQf0XilqNuy0lsFsFj7KfjsaI1TMXcsri/AYZBSbKGn8it9xlD6ls a1sQNv94EXcavXgnjvyCgvvs4PvgAqFOht2ZDF0/QO2DfJOUQnH/FqmYSDBsYupeYKvkTf+KdyY dTfQBufD9vSIrttB0 X-Received: by 2002:adf:d1cb:0:b0:22a:eae5:5c45 with SMTP id b11-20020adfd1cb000000b0022aeae55c45mr6300319wrd.255.1664553713989; Fri, 30 Sep 2022 09:01:53 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4gYaS2LsErTHtBUTm1K0N/TMQNG++aoXdlLuTqHi0RHmbObrbjweW7UC19SMflo13VeETvcw== X-Received: by 2002:adf:d1cb:0:b0:22a:eae5:5c45 with SMTP id b11-20020adfd1cb000000b0022aeae55c45mr6300297wrd.255.1664553713790; Fri, 30 Sep 2022 09:01:53 -0700 (PDT) Received: from localhost.localdomain ([92.62.32.42]) by smtp.gmail.com with ESMTPSA id i9-20020a1c5409000000b003b486027c8asm7348915wmb.20.2022.09.30.09.01.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 09:01:53 -0700 (PDT) Date: Fri, 30 Sep 2022 18:01:50 +0200 From: Guillaume Nault To: Nicolas Dichtel Cc: Hangbin Liu , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ido Schimmel , Petr Machata , Florent Fourcot , Nikolay Aleksandrov , David Ahern Subject: Re: [PATCHv5 net-next 1/4] rtnetlink: add new helper rtnl_configure_link_notify() Message-ID: <20220930160150.GD10057@localhost.localdomain> References: <20220930094506.712538-1-liuhangbin@gmail.com> <20220930094506.712538-2-liuhangbin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Sep 30, 2022 at 04:22:19PM +0200, Nicolas Dichtel wrote: > Le 30/09/2022 à 11:45, Hangbin Liu a écrit : > > -int rtnl_configure_link(struct net_device *dev, const struct ifinfomsg *ifm) > > +static int rtnl_configure_link_notify(struct net_device *dev, const struct ifinfomsg *ifm, > > + struct nlmsghdr *nlh, u32 pid) > But not here. Following patches also use this order instead of the previous one. > For consistency, it could be good to keep the same order everywhere. Yes, since a v6 will be necessary anyway, let's be consistent about the order of parameters. That helps reading the code. While there, I'd prefer to use 'portid' instead of 'pid'. I know rtnetlink.c uses both, but 'portid' is more explicit and is what af_netlink.c generally uses.