From: Guillaume Nault <gnault@redhat.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Ido Schimmel <idosch@nvidia.com>, Petr Machata <petrm@nvidia.com>,
Florent Fourcot <florent.fourcot@wifirst.fr>,
Nikolay Aleksandrov <razor@blackwall.org>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
David Ahern <dsahern@kernel.org>
Subject: Re: [PATCHv5 net-next 1/4] rtnetlink: add new helper rtnl_configure_link_notify()
Date: Fri, 30 Sep 2022 18:28:49 +0200 [thread overview]
Message-ID: <20220930162849.GE10057@localhost.localdomain> (raw)
In-Reply-To: <20220930094506.712538-2-liuhangbin@gmail.com>
> @@ -3856,7 +3856,7 @@ int __dev_change_flags(struct net_device *dev, unsigned int flags,
> int dev_change_flags(struct net_device *dev, unsigned int flags,
> struct netlink_ext_ack *extack);
> void __dev_notify_flags(struct net_device *, unsigned int old_flags,
> - unsigned int gchanges);
> + unsigned int gchanges, u32 pid, struct nlmsghdr *nlh);
In all the modified functions, you could make struct nlmsghdr * a const
pointer. You just need to also update rtnl_notify() to make its nlh
parameter const too.
> +void rtmsg_ifinfo_nlh(int type, struct net_device *dev, unsigned int change,
> + gfp_t flags, u32 pid, struct nlmsghdr *nlh)
> +{
> + rtmsg_ifinfo_event(type, dev, change, rtnl_get_event(0), flags,
> + NULL, 0, pid, nlh);
> }
Can't we just add the extra parameters to rtmsg_ifinfo() and trivially
adapt the few users to the new prototype? Maybe that's a personal
taste, but I find such wrapper unnecessary.
next prev parent reply other threads:[~2022-09-30 16:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 9:45 [PATCHv5 net-next 0/4] rtnetlink: Honour NLM_F_ECHO flag in rtnl_{new, del}link Hangbin Liu
2022-09-30 9:45 ` [PATCHv5 net-next 1/4] rtnetlink: add new helper rtnl_configure_link_notify() Hangbin Liu
2022-09-30 14:22 ` Nicolas Dichtel
2022-09-30 16:01 ` Guillaume Nault
2022-09-30 21:40 ` Nicolas Dichtel
2022-10-04 8:22 ` Hangbin Liu
2022-09-30 16:28 ` Guillaume Nault [this message]
2022-09-30 9:45 ` [PATCHv5 net-next 2/4] net: add new helper unregister_netdevice_many_notify Hangbin Liu
2022-09-30 14:23 ` Nicolas Dichtel
2022-09-30 14:29 ` Guillaume Nault
2022-09-30 15:18 ` Jakub Kicinski
2022-09-30 16:31 ` Guillaume Nault
2022-09-30 16:45 ` Guillaume Nault
2022-09-30 9:45 ` [PATCHv5 net-next 3/4] rtnetlink: Honour NLM_F_ECHO flag in rtnl_newlink_create Hangbin Liu
2022-09-30 16:42 ` Guillaume Nault
2022-09-30 9:45 ` [PATCHv5 net-next 4/4] rtnetlink: Honour NLM_F_ECHO flag in rtnl_delete_link Hangbin Liu
2022-09-30 16:57 ` Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220930162849.GE10057@localhost.localdomain \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=florent.fourcot@wifirst.fr \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).