From: Saeed Mahameed <saeedm@nvidia.com>
To: Alexandra Winter <wintera@linux.ibm.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Niklas Schnelle <schnelle@linux.ibm.com>,
netdev <netdev@vger.kernel.org>,
linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [RFC net] net/mlx5: Fix performance regression for request-response workloads
Date: Fri, 30 Sep 2022 16:37:08 -0700 [thread overview]
Message-ID: <20220930233708.kfxhgn2ytmraqhg7@sfedora> (raw)
In-Reply-To: <886c690b-cc35-39a0-8397-834e70fb329b@linux.ibm.com>
On 26 Sep 12:06, Alexandra Winter wrote:
>
[ ... ]
>[...]
>
>Saeed,
>As discussed at LPC, could you please consider adding a workaround to the
>Mellanox driver, to use non-SG SKBs for small messages? As mentioned above
>we are seeing 13% throughput degradation, if 2 pages need to be mapped
>instead of 1.
>
>While Eric's ideas sound very promising, just using non-SG in these cases
>should be enough to mitigate the performance regression we see.
Hi Alexandra, sorry for the late response.
Yeas linearizing small messages makes sense, but will require some careful
perf testing.
We will do our best to include this in the next kernel release cycle.
I will take it with the mlx5e team next week, everybody is on vacation this
time of year :).
Thanks,
Saeed.
next prev parent reply other threads:[~2022-09-30 23:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 12:25 [RFC net] tcp: Fix performance regression for request-response workloads Alexandra Winter
2022-09-07 16:06 ` Eric Dumazet
2022-09-08 9:40 ` Christian Borntraeger
2022-09-08 12:41 ` Eric Dumazet
2022-09-26 10:06 ` [RFC net] net/mlx5: " Alexandra Winter
2022-09-30 23:37 ` Saeed Mahameed [this message]
2022-12-29 8:27 ` Alexandra Winter
2023-04-27 9:44 ` Alexandra Winter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220930233708.kfxhgn2ytmraqhg7@sfedora \
--to=saeedm@nvidia.com \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hca@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=schnelle@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox