Re: [RFC PATCH net-next 2/7] net: ethtool: add support for Frame Preemption and MAC Merge layer

Jakub Kicinski
2022-08-17T03:22:17Z

On Wed, 17 Aug 2022 01:29:15 +0300 Vladimir Oltean wrote:
> +/**
> + * struct ethtool_mm_state - 802.3 MAC merge layer state
> + */
> +struct ethtool_mm_state {
> + u32 verify_time;
> + enum ethtool_mm_verify_status verify_status;
> + bool supported;
> + bool enabled;
> + bool active;

The enabled vs active piqued my interest. Is there some handshake /
aneg or such?

> + nest_table = nla_nest_start(skb, ETHTOOL_A_FP_PARAM_TABLE);
> + if (!nest_table)
> + return -EMSGSIZE;

Don't warp tables in nests, let the elements repeat in the parent.