Re: [RFC PATCH net-next 0/7] 802.1Q Frame Preemption and 802.3 MAC Merge support via ethtool

Jakub Kicinski
2022-08-17T03:34:25Z

On Wed, 17 Aug 2022 01:29:13 +0300 Vladimir Oltean wrote:
> What also exists but is not exported here are PAUSE stats for the
> pMAC. Since those are also protocol-specific stats, I'm not sure how
> to mix the 2 (MAC Merge layer + PAUSE). Maybe just extend
> ETHTOOL_A_PAUSE_STAT_TX_FRAMES and ETHTOOL_A_PAUSE_STAT_RX_FRAMES with
> the pMAC variants?

I have a couple of general questions. The mm and fp are related but fp
can be implemented without mm or they must always come together? (I'd
still split patch 2 for ease of review, tho.)

When we have separate set of stats for pMAC the normal stats are sum of
all traffic, right? So normal - pMAC == eMAC, everything that's not
preemptible is express?

Did you consider adding an attribute for switching between MAC and pMAC
for stats rather than duplicating things?