From: Guenter Roeck <linux@roeck-us.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, liuhangbin@gmail.com, mkl@pengutronix.de
Subject: Re: [PATCH net-next] eth: octeon: fix build after netif_napi_add() changes
Date: Sun, 2 Oct 2022 15:54:01 -0700 [thread overview]
Message-ID: <20221002225401.GA1000012@roeck-us.net> (raw)
On Sun, Oct 02, 2022 at 10:56:50AM -0700, Jakub Kicinski wrote:
> Guenter reports I missed a netif_napi_add() call
> in one of the platform-specific drivers:
>
> drivers/net/ethernet/cavium/octeon/octeon_mgmt.c: In function 'octeon_mgmt_probe':
> drivers/net/ethernet/cavium/octeon/octeon_mgmt.c:1399:9: error: too many arguments to function 'netif_napi_add'
> 1399 | netif_napi_add(netdev, &p->napi, octeon_mgmt_napi_poll,
> | ^~~~~~~~~~~~~~
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Fixes: b48b89f9c189 ("net: drop the weight argument from netif_napi_add")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
> CC: liuhangbin@gmail.com
> CC: mkl@pengutronix.de
> ---
> drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
> index 369bfd376d6f..edde0b8fa49c 100644
> --- a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
> +++ b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
> @@ -1396,8 +1396,8 @@ static int octeon_mgmt_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, netdev);
> p = netdev_priv(netdev);
> - netif_napi_add(netdev, &p->napi, octeon_mgmt_napi_poll,
> - OCTEON_MGMT_NAPI_WEIGHT);
> + netif_napi_add_weight(netdev, &p->napi, octeon_mgmt_napi_poll,
> + OCTEON_MGMT_NAPI_WEIGHT);
>
> p->netdev = netdev;
> p->dev = &pdev->dev;
> --
> 2.37.3
>
next reply other threads:[~2022-10-02 23:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 22:54 Guenter Roeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-10-02 17:56 [PATCH net-next] eth: octeon: fix build after netif_napi_add() changes Jakub Kicinski
2022-10-04 0:25 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221002225401.GA1000012@roeck-us.net \
--to=linux@roeck-us.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).