Re: [PATCH -next] net: ena: Remove unused variable 'tx_bytes'

Re: [PATCH -next] net: ena: Remove unused variable 'tx_bytes'

[Shay Agroskin]

Chen Zhongjin <chenzhongjin@huawei.com> writes:

> CAUTION: This email originated from outside of the 
> organization. Do not click links or open attachments unless you 
> can confirm the sender and know the content is safe.
>
>
>
> Reported by Clang [-Wunused-but-set-variable]
>
> 'commit 548c4940b9f1 ("net: ena: Implement XDP_TX action")'
> This commit introduced the variable 'tx_bytes'. However this 
> variable
> is never used by other code except iterates itself, so remove 
> it.
>
> Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
> ---
>  drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c 
> b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> index 6a356a6cee15..c8dfb9287856 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> @@ -1876,7 +1876,6 @@ static int ena_clean_xdp_irq(struct 
> ena_ring *xdp_ring, u32 budget)
>  {
>         u32 total_done = 0;
>         u16 next_to_clean;
> -       u32 tx_bytes = 0;
>         int tx_pkts = 0;
>         u16 req_id;
>         int rc;
> @@ -1914,7 +1913,6 @@ static int ena_clean_xdp_irq(struct 
> ena_ring *xdp_ring, u32 budget)
>                           "tx_poll: q %d skb %p completed\n", 
>                           xdp_ring->qid,
>                           xdpf);
>
> -               tx_bytes += xdpf->len;
>                 tx_pkts++;
>                 total_done += tx_info->tx_descs;

Nice catch. Thanks

Acked-by: Shay Agroskin <shayagr@amazon.com>

Re: [PATCH -next] net: ena: Remove unused variable 'tx_bytes'

[Jakub Kicinski]

On Mon, 10 Oct 2022 11:19:36 +0800 Chen Zhongjin wrote:
> Reported by Clang [-Wunused-but-set-variable]
> 
> 'commit 548c4940b9f1 ("net: ena: Implement XDP_TX action")'
> This commit introduced the variable 'tx_bytes'. However this variable
> is never used by other code except iterates itself, so remove it.

First of all - please fix the date on your system.

Second:

# Form letter - net-next is closed

Linus has released v6.0, we are currently in a merge window
and therefore net-next is closed for new drivers, features,
code refactoring and optimizations. We are currently accepting
bug fixes only.

Please repost when net-next reopens after 6.1-rc1 is cut.

RFC patches sent for review only are obviously welcome at any time.

[PATCH -next] net: ena: Remove unused variable 'tx_bytes'

[Chen Zhongjin]

Reported by Clang [-Wunused-but-set-variable]

'commit 548c4940b9f1 ("net: ena: Implement XDP_TX action")'
This commit introduced the variable 'tx_bytes'. However this variable
is never used by other code except iterates itself, so remove it.

Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
---
 drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index 6a356a6cee15..c8dfb9287856 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -1876,7 +1876,6 @@ static int ena_clean_xdp_irq(struct ena_ring *xdp_ring, u32 budget)
 {
 	u32 total_done = 0;
 	u16 next_to_clean;
-	u32 tx_bytes = 0;
 	int tx_pkts = 0;
 	u16 req_id;
 	int rc;
@@ -1914,7 +1913,6 @@ static int ena_clean_xdp_irq(struct ena_ring *xdp_ring, u32 budget)
 			  "tx_poll: q %d skb %p completed\n", xdp_ring->qid,
 			  xdpf);
 
-		tx_bytes += xdpf->len;
 		tx_pkts++;
 		total_done += tx_info->tx_descs;
 
-- 
2.33.0