From: Jakub Kicinski <kuba@kernel.org>
To: Yinjun Zhang <yinjun.zhang@corigine.com>
Cc: Simon Horman <simon.horman@corigine.com>,
David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, oss-drivers@corigine.com,
Fei Qin <fei.qin@corigine.com>
Subject: Re: [PATCH net-next v2 0/5] nfp: support FEC mode reporting and auto-neg
Date: Mon, 3 Oct 2022 13:01:49 -0700 [thread overview]
Message-ID: <20221003130149.07f38aaf@kernel.org> (raw)
In-Reply-To: <20221003084111.GA39850@nj-rack01-04.nji.corigine.com>
On Mon, 3 Oct 2022 16:41:11 +0800 Yinjun Zhang wrote:
> > Looks better, thanks for the changes.
> >
> > BTW shouldn't the sp_indiff symbol be prefixed by _pf%u ?
> > That's not really introduced by this series tho.
>
> Thanks for your advice. Although sp_indiff is exposed by per-PF rtsym
> _pf%u_net_app_cap, which can be used for per-PF capabilities in future,
> I think sp_indiff won't be inconsistent among PFs. We'll adjust it if
> it happens.
It's not about inconsistencies but about the fact that in multi-host
systems there are multiple driver instances which come and go.
The driver seems to set sp_indiff to one at load and to zero when it
unloads. IDK what that actually does to the FW but if it does anything
it's not gonna work reliably in MH.
next prev parent reply other threads:[~2022-10-03 20:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 8:58 [PATCH net-next v2 0/5] nfp: support FEC mode reporting and auto-neg Simon Horman
2022-09-29 8:58 ` [PATCH net-next v2 1/5] nfp: add support for reporting active FEC mode Simon Horman
2022-09-29 8:58 ` [PATCH net-next v2 2/5] nfp: avoid halt of driver init process when non-fatal error happens Simon Horman
2022-09-29 8:58 ` [PATCH net-next v2 3/5] nfp: refine the ABI of getting `sp_indiff` info Simon Horman
2022-09-29 8:58 ` [PATCH net-next v2 4/5] nfp: add support for link auto negotiation Simon Horman
2022-09-29 8:58 ` [PATCH net-next v2 5/5] nfp: add support restart of link auto-negotiation Simon Horman
2022-10-01 1:47 ` [PATCH net-next v2 0/5] nfp: support FEC mode reporting and auto-neg Jakub Kicinski
2022-10-03 8:41 ` Yinjun Zhang
2022-10-03 20:01 ` Jakub Kicinski [this message]
2022-10-04 2:04 ` Yinjun Zhang
2022-10-01 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221003130149.07f38aaf@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=fei.qin@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=yinjun.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).