From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5622AC433FE for ; Tue, 4 Oct 2022 00:08:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229881AbiJDAIw (ORCPT ); Mon, 3 Oct 2022 20:08:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbiJDAIv (ORCPT ); Mon, 3 Oct 2022 20:08:51 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1ADA0F5AE; Mon, 3 Oct 2022 17:08:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 778FCCE0F7F; Tue, 4 Oct 2022 00:08:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D3DDC433C1; Tue, 4 Oct 2022 00:08:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664842126; bh=YNqwNduPcb5thmEiOwSsCHdrAP2D+Xzxs6/sckI4nI8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mQi4ybdpjq2Vt0bvLT682IVB4ICnquisO8ekuTRRQ4XG3kXB34jKCKngUOyH2F9XK Z4c/QxaQlNsgMgT1kHuzKJMFRS3nn5HMtBTobnPebEEES6+yXCJQbPtrQQY6rF7DoZ ETqzD+VDJOh8QD7Tz63C1BUlh1dNX4YhEmO1wJhUREx5vAb5aqEPPLPG7Brn/z1mtE 1k7ia8ECHD9KdLbmbSIimnwBDJhCI7mYnTiEU1QMGXG4ZyFXg/0H/q1VZZHXtwC0ty 7GJgzoojgtpkrazTSai+GNNZm8FKfuTKsx5c/OhTrq76EBRoKGCochLYmLoO0sxo2H bvVf/hvi9iTkQ== Date: Mon, 3 Oct 2022 17:08:45 -0700 From: Jakub Kicinski To: Divya Koppera Cc: , , , , , , , , Subject: Re: [PATCH net] net: phy: micrel: Fixes FIELD_GET assertion Message-ID: <20221003170845.1fec4353@kernel.org> In-Reply-To: <20221003063130.17782-1-Divya.Koppera@microchip.com> References: <20221003063130.17782-1-Divya.Koppera@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 3 Oct 2022 12:01:30 +0530 Divya Koppera wrote: > FIELD_GET() must only be used with a mask that is a compile-time > constant. Mark the functions as __always_inline to avoid the problem. > > Fixes: 21b688dabecb6a ("net: phy: micrel: Cable Diag feature for lan8814 phy") Does not apply cleanly to net, please rebase & resend.