From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <pabeni@redhat.com>
Cc: <davem@davemloft.net>, <dsahern@kernel.org>,
<edumazet@google.com>, <kuba@kernel.org>, <kuni1840@gmail.com>,
<kuniyu@amazon.com>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <syzkaller-bugs@googlegroups.com>,
<vyasevic@redhat.com>, <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH RESEND v3 net 3/5] tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().
Date: Tue, 4 Oct 2022 07:55:24 -0700 [thread overview]
Message-ID: <20221004145524.32829-1-kuniyu@amazon.com> (raw)
In-Reply-To: <122af5c891fcc65fb6179ec53a89374daa4600aa.camel@redhat.com>
From: Paolo Abeni <pabeni@redhat.com>
Date: Tue, 04 Oct 2022 12:21:20 +0200
> Hello,
>
> On Mon, 2022-10-03 at 08:44 -0700, Kuniyuki Iwashima wrote:
> [...]
> > @@ -1723,7 +1736,7 @@ struct proto udpv6_prot = {
> > .connect = ip6_datagram_connect,
> > .disconnect = udp_disconnect,
> > .ioctl = udp_ioctl,
> > - .init = udp_init_sock,
> > + .init = udpv6_init_sock,
> > .destroy = udpv6_destroy_sock,
> > .setsockopt = udpv6_setsockopt,
> > .getsockopt = udpv6_getsockopt,
>
> It looks like even UDPv6 lite can be ADDRFORMed to ipv4, so I guess we
> need a similar chunk for udplitev6_prot? With that we can unexport
> udp_init_sock, I guess.
Good catch!
Yes, I'll add that changes in v4.
Thank you.
next prev parent reply other threads:[~2022-10-04 15:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 15:44 [PATCH RESEND v3 net 0/5] tcp/udp: Fix memory leaks and data races around IPV6_ADDRFORM Kuniyuki Iwashima
2022-10-03 15:44 ` [PATCH RESEND v3 net 1/5] tcp/udp: Fix memory leak in ipv6_renew_options() Kuniyuki Iwashima
2022-10-03 15:44 ` [PATCH RESEND v3 net 2/5] udp: Call inet6_destroy_sock() in setsockopt(IPV6_ADDRFORM) Kuniyuki Iwashima
2022-10-03 15:44 ` [PATCH RESEND v3 net 3/5] tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct() Kuniyuki Iwashima
2022-10-04 10:21 ` Paolo Abeni
2022-10-04 14:55 ` Kuniyuki Iwashima [this message]
2022-10-03 15:44 ` [PATCH RESEND v3 net 4/5] ipv6: Fix data races around sk->sk_prot Kuniyuki Iwashima
2022-10-03 15:44 ` [PATCH RESEND v3 net 5/5] tcp: Fix data races around icsk->icsk_af_ops Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221004145524.32829-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=vyasevic@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).