From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D49E4C4332F for ; Wed, 5 Oct 2022 00:23:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229583AbiJEAXk (ORCPT ); Tue, 4 Oct 2022 20:23:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229587AbiJEAXj (ORCPT ); Tue, 4 Oct 2022 20:23:39 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83727564CE; Tue, 4 Oct 2022 17:23:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 423C2B81C4A; Wed, 5 Oct 2022 00:23:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D07BC433D6; Wed, 5 Oct 2022 00:23:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664929416; bh=mD2LhzbA1iNs/rh93HQfgura4zsxg+NMKqeLVu1NIjY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aDBNU+BgzpTyr6yGIvISpEwHfm+2L1vy7GF/sgfKOEbOGU4EaYdOzNCILp27ei3m3 rW3PP+D4Uc7G9fF/YHMtcs7WjK6f6GptN3+ETHikB9RP09pOfKQ//f38/CrYXPtKb9 g+b7jBS6jmHHVOlwmEI6IOQ0hL3tC+eAsOGlPISZaDnHiobRmNSylsYTcAW+yH5sQ4 mgGEnICPC35b+ICJKF/AUMrDrIh+oDAuQjphn2RAu/PvqvHQbhZwsufkuIVtX8b+po Kbsd+2iJ8gzqnw2YGIe2zp0XaksS71SREDZhy0d4Zqcx3YJfDUYWE3jLiTW/eQGPo7 /+dd34UeROEew== Date: Tue, 4 Oct 2022 17:23:34 -0700 From: Jakub Kicinski To: Kees Cook Cc: Dmitry Vyukov , syzbot , bpf@vger.kernel.org, davem@davemloft.net, edumazet@google.com, fw@strlen.de, harshit.m.mogalapalli@oracle.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, syzkaller-bugs@googlegroups.com, linux-hardening@vger.kernel.org Subject: Re: [syzbot] upstream boot error: WARNING in netlink_ack Message-ID: <20221004172334.2cb0233e@kernel.org> In-Reply-To: <20221004170400.52c97523@kernel.org> References: <000000000000a793cc05ea313b87@google.com> <20221004104253.29c1f3c7@kernel.org> <202210041600.7C90DF917@keescook> <20221004170400.52c97523@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 4 Oct 2022 17:04:00 -0700 Jakub Kicinski wrote: > > why does a fixed size mean no memset? > > Copy and paste, it seems to originate from: > > 0c19b0adb8dd ("netlink: avoid memset of 0 bytes sparse warning") > > Any idea why sparse would not like empty memsets? Google answers is. Let me test if sparse still wants the workaround.