From: Jakub Kicinski <kuba@kernel.org>
To: Stephen Hemminger <stephen@networkplumber.org>,
Peter Kosyh <pkosyh@yandex.ru>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] net: benet: use snprintf instead sprintf and IFNAMSIZ instead hardcoded constant.
Date: Tue, 4 Oct 2022 17:30:46 -0700 [thread overview]
Message-ID: <20221004173046.5ec6d3ca@kernel.org> (raw)
In-Reply-To: <20221004082936.0d0c9bcb@hermes.local>
On Tue, 4 Oct 2022 08:29:36 -0700 Stephen Hemminger wrote:
> On Tue, 4 Oct 2022 12:50:34 +0300
> Peter Kosyh <pkosyh@yandex.ru> wrote:
>
> > printf to array 'eqo->desc' of size 32 may cause buffer overflow when
> > using non-standard IFNAMSIZ.
> >
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >
> > Signed-off-by: Peter Kosyh <pkosyh@yandex.ru>
>
> NACK
> Non-standard IFNAMSIZ will break uapi and many things.
> I see no reason for kernel or tools like iproute2 to support or
> fix those related bugs.
I think the commit message is missing the point, but the warning
may be legit.
Pater please read the requirements for sending patches based on
automated checkers:
Documentation/process/researcher-guidelines.rst
prev parent reply other threads:[~2022-10-05 0:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 9:50 [PATCH] net: benet: use snprintf instead sprintf and IFNAMSIZ instead hardcoded constant Peter Kosyh
2022-10-04 15:29 ` Stephen Hemminger
2022-10-05 0:30 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221004173046.5ec6d3ca@kernel.org \
--to=kuba@kernel.org \
--cc=ajit.khaparde@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkosyh@yandex.ru \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).