* [PATCH] net: pse-pd: PSE_REGULATOR should depend on REGULATOR
@ 2022-10-04 16:23 Geert Uytterhoeven
2022-10-05 6:36 ` Oleksij Rempel
2022-10-06 4:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2022-10-04 16:23 UTC (permalink / raw)
To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Andrew Lunn, Oleksij Rempel
Cc: netdev, linux-kernel, Geert Uytterhoeven
The Regulator based PSE controller driver relies on regulator support to
be enabled. If regulator support is disabled, it will still compile
fine, but won't operate correctly.
Hence add a dependency on REGULATOR, to prevent asking the user about
this driver when configuring a kernel without regulator support.
Fixes: 66741b4e94ca7bb1 ("net: pse-pd: add regulator based PSE driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/net/pse-pd/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/pse-pd/Kconfig b/drivers/net/pse-pd/Kconfig
index 73d163704068ac27..687dec49c1e13fa0 100644
--- a/drivers/net/pse-pd/Kconfig
+++ b/drivers/net/pse-pd/Kconfig
@@ -14,6 +14,7 @@ if PSE_CONTROLLER
config PSE_REGULATOR
tristate "Regulator based PSE controller"
+ depends on REGULATOR || COMPILE_TEST
help
This module provides support for simple regulator based Ethernet Power
Sourcing Equipment without automatic classification support. For
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: pse-pd: PSE_REGULATOR should depend on REGULATOR
2022-10-04 16:23 [PATCH] net: pse-pd: PSE_REGULATOR should depend on REGULATOR Geert Uytterhoeven
@ 2022-10-05 6:36 ` Oleksij Rempel
2022-10-06 4:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Oleksij Rempel @ 2022-10-05 6:36 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Andrew Lunn, Oleksij Rempel, netdev, linux-kernel
On Tue, Oct 04, 2022 at 06:23:53PM +0200, Geert Uytterhoeven wrote:
> The Regulator based PSE controller driver relies on regulator support to
> be enabled. If regulator support is disabled, it will still compile
> fine, but won't operate correctly.
>
> Hence add a dependency on REGULATOR, to prevent asking the user about
> this driver when configuring a kernel without regulator support.
>
> Fixes: 66741b4e94ca7bb1 ("net: pse-pd: add regulator based PSE driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Thank you!
> ---
> drivers/net/pse-pd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/pse-pd/Kconfig b/drivers/net/pse-pd/Kconfig
> index 73d163704068ac27..687dec49c1e13fa0 100644
> --- a/drivers/net/pse-pd/Kconfig
> +++ b/drivers/net/pse-pd/Kconfig
> @@ -14,6 +14,7 @@ if PSE_CONTROLLER
>
> config PSE_REGULATOR
> tristate "Regulator based PSE controller"
> + depends on REGULATOR || COMPILE_TEST
> help
> This module provides support for simple regulator based Ethernet Power
> Sourcing Equipment without automatic classification support. For
> --
> 2.25.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: pse-pd: PSE_REGULATOR should depend on REGULATOR
2022-10-04 16:23 [PATCH] net: pse-pd: PSE_REGULATOR should depend on REGULATOR Geert Uytterhoeven
2022-10-05 6:36 ` Oleksij Rempel
@ 2022-10-06 4:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-10-06 4:00 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: davem, edumazet, kuba, pabeni, andrew, linux, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 4 Oct 2022 18:23:53 +0200 you wrote:
> The Regulator based PSE controller driver relies on regulator support to
> be enabled. If regulator support is disabled, it will still compile
> fine, but won't operate correctly.
>
> Hence add a dependency on REGULATOR, to prevent asking the user about
> this driver when configuring a kernel without regulator support.
>
> [...]
Here is the summary with links:
- net: pse-pd: PSE_REGULATOR should depend on REGULATOR
https://git.kernel.org/netdev/net/c/304ee24bdb43
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-06 4:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-04 16:23 [PATCH] net: pse-pd: PSE_REGULATOR should depend on REGULATOR Geert Uytterhoeven
2022-10-05 6:36 ` Oleksij Rempel
2022-10-06 4:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).