From: Joe Damato <jdamato@fastly.com>
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net,
anthony.l.nguyen@intel.com, jesse.brandeburg@intel.com,
maciej.fijalkowski@intel.com
Subject: Re: [next-queue v2 3/4] i40e: Record number of RXes cleaned during NAPI
Date: Wed, 5 Oct 2022 17:36:44 -0700 [thread overview]
Message-ID: <20221006003643.GB30279@fastly.com> (raw)
In-Reply-To: <1665004913-25656-4-git-send-email-jdamato@fastly.com>
On Wed, Oct 05, 2022 at 02:21:52PM -0700, Joe Damato wrote:
> Adjust i40e_clean_rx_irq and i40e_clean_rx_irq_zc to accept an out
> parameter which records the number of RX packets cleaned.
I just realized that this change probably also needs to include an
"rx_clean_complete" as was added in the previous patch for the TX case so
that when the tracepoint is hit it will be more clear which of the two (RX or
TX) triggered clean_complete = false.
I think the tracepoint should have separate bool flags for each of these
cases (but neither will be used to modify control flow as Jesse asked
earlier).
I'll leave that fix for the v3, in addition to addressing any other feedback on
the rest of the changes.
next prev parent reply other threads:[~2022-10-06 0:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 21:21 [next-queue v2 0/4] i40e: Add an i40e_napi_poll tracepoint Joe Damato
2022-10-05 21:21 ` [next-queue v2 1/4] i40e: Store the irq number in i40e_q_vector Joe Damato
2022-10-05 21:21 ` [next-queue v2 2/4] i40e: Record number TXes cleaned during NAPI Joe Damato
2022-10-06 0:16 ` Samudrala, Sridhar
2022-10-06 0:31 ` Joe Damato
2022-10-06 1:00 ` Joe Damato
2022-10-06 13:03 ` Maciej Fijalkowski
2022-10-06 14:57 ` Samudrala, Sridhar
2022-10-06 17:32 ` Joe Damato
2022-10-06 22:35 ` Jesse Brandeburg
2022-10-06 22:56 ` Joe Damato
2022-10-07 8:08 ` Maciej Fijalkowski
2022-10-05 21:21 ` [next-queue v2 3/4] i40e: Record number of RXes " Joe Damato
2022-10-06 0:36 ` Joe Damato [this message]
2022-10-05 21:21 ` [next-queue v2 4/4] i40e: Add i40e_napi_poll tracepoint Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221006003643.GB30279@fastly.com \
--to=jdamato@fastly.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).