From: Jakub Kicinski <kuba@kernel.org>
To: Guillaume Nault <gnault@redhat.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, robh@kernel.org, johannes@sipsolutions.net,
ecree.xilinx@gmail.com, stephen@networkplumber.org,
sdf@google.com, f.fainelli@gmail.com, fw@strlen.de,
linux-doc@vger.kernel.org, razor@blackwall.org,
nicolas.dichtel@6wind.com
Subject: Re: [PATCH net-next v2 3/7] net: add basic C code generators for Netlink
Date: Thu, 6 Oct 2022 07:55:37 -0700 [thread overview]
Message-ID: <20221006075537.0a3b2bb2@kernel.org> (raw)
In-Reply-To: <20221006125109.GE3328@localhost.localdomain>
On Thu, 6 Oct 2022 14:51:09 +0200 Guillaume Nault wrote:
> > v2: - use /* */ comments instead of //
>
> Probably not a very interesting feedback, but there
> are still many comments generated in the // style.
It's slightly unclear to me what our policy on comments is now.
I can fix all up - the motivation for the change in v2 was that
in uAPI apparently its completely forbidden to use anything that's
not ANSI C :S
Gotta keep that compatibility with the all important Borland compiler
or something?
next prev parent reply other threads:[~2022-10-06 14:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 2:34 [PATCH net-next v2 0/7] Netlink protocol specs Jakub Kicinski
2022-09-30 2:34 ` [PATCH net-next v2 1/7] docs: add more netlink docs (incl. spec docs) Jakub Kicinski
2022-10-10 9:56 ` Guillaume Nault
2022-09-30 2:34 ` [PATCH net-next v2 2/7] netlink: add schemas for YAML specs Jakub Kicinski
2022-09-30 2:34 ` [PATCH net-next v2 3/7] net: add basic C code generators for Netlink Jakub Kicinski
2022-10-06 12:51 ` Guillaume Nault
2022-10-06 14:55 ` Jakub Kicinski [this message]
2022-10-07 8:54 ` Guillaume Nault
2022-09-30 2:34 ` [PATCH net-next v2 4/7] netlink: add a proto specification for FOU Jakub Kicinski
2022-09-30 2:34 ` [PATCH net-next v2 5/7] net: fou: regenerate the uAPI from the spec Jakub Kicinski
2022-09-30 2:34 ` [PATCH net-next v2 6/7] net: fou: rename the source for linking Jakub Kicinski
2022-09-30 2:34 ` [PATCH net-next v2 7/7] net: fou: use policy and operation tables generated from the spec Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221006075537.0a3b2bb2@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=fw@strlen.de \
--cc=gnault@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=robh@kernel.org \
--cc=sdf@google.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).