From: Jakub Kicinski <kuba@kernel.org>
To: LABBE Corentin <clabbe@baylibre.com>
Cc: davem@davemloft.net, edumazet@google.com, khalasa@piap.pl,
pabeni@redhat.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/4] net: ethernet: xscale: fix space style issues
Date: Thu, 6 Oct 2022 08:06:51 -0700 [thread overview]
Message-ID: <20221006080651.6cc91dd7@kernel.org> (raw)
In-Reply-To: <Yz5cP82JRuvZHh+I@Red>
On Thu, 6 Oct 2022 06:40:31 +0200 LABBE Corentin wrote:
> The difference with classic checkpatch is that I have tested it.
If you make some material changes to the driver I'd reconsider,
otherwise I'd strongly prefer to stick to the general policy.
> And the patch #2 fixes the bad netdev_debug().
Please isolate that from the noise and send it separately
(after net-next opens).
prev parent reply other threads:[~2022-10-06 15:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 12:04 [PATCH 1/4] net: ethernet: xscale: fix space style issues Corentin Labbe
2022-10-05 12:04 ` [PATCH 2/4] net: ethernet: xscale: fix printk issues Corentin Labbe
2022-10-05 12:05 ` [PATCH 3/4] net: ethernet: xscale: remove assignment in if condition Corentin Labbe
2022-10-05 12:05 ` [PATCH 4/4] net: ethernet: xscale: fix easy remaining style issues Corentin Labbe
2022-10-06 3:35 ` [PATCH 1/4] net: ethernet: xscale: fix space " Jakub Kicinski
2022-10-06 4:40 ` LABBE Corentin
2022-10-06 15:06 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221006080651.6cc91dd7@kernel.org \
--to=kuba@kernel.org \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=khalasa@piap.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).