From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: "Jaron, MichalX" <michalx.jaron@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Maziarz, Kamil" <kamil.maziarz@intel.com>,
"G, GurucharanX" <gurucharanx.g@intel.com>,
"Dziedziuch, SylwesterX" <sylwesterx.dziedziuch@intel.com>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Subject: Re: [PATCH net 2/3] i40e: Fix not setting xps_cpus after reset
Date: Thu, 6 Oct 2022 17:11:51 -0700 [thread overview]
Message-ID: <20221006171151.3090bf13@kernel.org> (raw)
In-Reply-To: <ddf02cb6-0ad4-0396-79f7-bd12a5c8d552@intel.com>
On Thu, 6 Oct 2022 15:28:47 -0700 Tony Nguyen wrote:
> The version with updated commit message[1] is on Intel Wired LAN but I'm
> not sure whether your comment still stands or if this is ok after the
> explanation/updated message.
As far as I know wiping XPS on ethtool -L is what most drivers do. We
need to have a discussion about who is expecting the config to not get
wiped and under what conditions. Then think about ways of doing this
generically.
The local driver patches are a no-go from my PoV.
next prev parent reply other threads:[~2022-10-07 0:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 20:32 [PATCH net 0/3][pull request] Intel Wired LAN Driver Updates 2022-09-26 (i40e) Tony Nguyen
2022-09-26 20:32 ` [PATCH net 1/3] i40e: Fix ethtool rx-flow-hash setting for X722 Tony Nguyen
2022-09-26 20:32 ` [PATCH net 2/3] i40e: Fix not setting xps_cpus after reset Tony Nguyen
2022-09-28 1:29 ` Jakub Kicinski
2022-09-28 13:32 ` Jaron, MichalX
2022-09-28 14:11 ` Jakub Kicinski
2022-09-29 11:58 ` Jaron, MichalX
2022-10-06 22:28 ` Tony Nguyen
2022-10-07 0:11 ` Jakub Kicinski [this message]
2022-09-28 18:26 ` Tony Nguyen
2022-09-26 20:32 ` [PATCH net 3/3] i40e: Fix DMA mappings leak Tony Nguyen
2022-09-27 2:58 ` Rout, ChandanX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221006171151.3090bf13@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gurucharanx.g@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=kamil.maziarz@intel.com \
--cc=michalx.jaron@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sylwesterx.dziedziuch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).