From: Jakub Kicinski <kuba@kernel.org>
To: Edward Cree <ecree.xilinx@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
ecree@xilinx.com, netdev@vger.kernel.org,
linux-net-drivers@amd.com, davem@davemloft.net,
pabeni@redhat.com, edumazet@google.com, habetsm.xilinx@gmail.com,
marcelo.leitner@gmail.com
Subject: Re: [RFC PATCH net-next 1/3] netlink: add support for formatted extack messages
Date: Fri, 7 Oct 2022 11:32:19 -0700 [thread overview]
Message-ID: <20221007113219.74aede95@kernel.org> (raw)
In-Reply-To: <1aafd0ec-5e01-9b01-61a5-48f3945c3969@gmail.com>
On Fri, 7 Oct 2022 14:46:46 +0100 Edward Cree wrote:
> > That "if (__extack)" check seems a bit strange, you've long crashed with
> > a NPD if it was really NULL?
>
> Good point, I blindly copied NL_SET_ERR_MSG without thinking.
> The check should enclose the whole body, will fix in v2.
FWIW you can prolly use break; thanks to the do {} while wrapping.
Maybe that's hacky.
next prev parent reply other threads:[~2022-10-07 18:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 13:25 [RFC PATCH net-next 0/3] netlink: formatted extacks ecree
2022-10-07 13:25 ` [RFC PATCH net-next 1/3] netlink: add support for formatted extack messages ecree
2022-10-07 13:35 ` Johannes Berg
2022-10-07 13:46 ` Edward Cree
2022-10-07 13:49 ` Johannes Berg
2022-10-07 13:58 ` Edward Cree
2022-10-13 12:59 ` Jiri Pirko
2022-10-13 13:35 ` Edward Cree
2022-10-07 18:32 ` Jakub Kicinski [this message]
2022-10-13 12:55 ` Jiri Pirko
2022-10-17 12:00 ` Edward Cree
2022-10-17 18:44 ` Jakub Kicinski
2022-10-07 13:25 ` [RFC PATCH net-next 2/3] sfc: use formatted extacks instead of efx_tc_err() ecree
2022-10-07 13:25 ` [RFC PATCH net-next 3/3] sfc: remove 'log-tc-errors' ethtool private flag ecree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221007113219.74aede95@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=ecree@xilinx.com \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-net-drivers@amd.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).