From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1FC2C433F5 for ; Sun, 9 Oct 2022 23:41:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232141AbiJIXlu (ORCPT ); Sun, 9 Oct 2022 19:41:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231882AbiJIXlV (ORCPT ); Sun, 9 Oct 2022 19:41:21 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C364D9AFE3; Sun, 9 Oct 2022 16:13:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A3B9EB80DCD; Sun, 9 Oct 2022 22:24:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65FD7C433D6; Sun, 9 Oct 2022 22:24:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665354283; bh=qauSKgpxQD3mSoJYIZLLYiRX2nOUMjRG4equd7WLjdc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GaBMQzxJ2uA0N88/lbxoc2RvDJMUegqXjU/810J9qe/lBJVAbewb/OFQ3zXiZaGEb B/oC7JUqzP4xOYBN/RuPyxKJyfTeUElRlnHVjGS9k3r21ZQvZo6Oq6NFh9zmPPGfiA /NCrbjplfx8QFhltkrThUQx+R3EwD8KBFhC55yWyAiIcbWJF0iQd70StOLHuO6USWU rtQOdGLPlOin9yEUKqCd0NpFqVFML+Y3HFK/i1ALdbv/twOL4/+D5aCw7n6BPyqSVw MU7R0SgR32y3JjVJmrPz9QsebbcmE11suQfLPEdN5v1UWwkVGTGFMhmk46wjfkmxTl +dBdTvxtEJbAg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mike Pattrick , "David S . Miller" , Sasha Levin , pshelar@ovn.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, dev@openvswitch.org Subject: [PATCH AUTOSEL 4.19 03/25] openvswitch: Fix overreporting of drops in dropwatch Date: Sun, 9 Oct 2022 18:24:08 -0400 Message-Id: <20221009222436.1219411-3-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221009222436.1219411-1-sashal@kernel.org> References: <20221009222436.1219411-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Mike Pattrick [ Upstream commit c21ab2afa2c64896a7f0e3cbc6845ec63dcfad2e ] Currently queue_userspace_packet will call kfree_skb for all frames, whether or not an error occurred. This can result in a single dropped frame being reported as multiple drops in dropwatch. This functions caller may also call kfree_skb in case of an error. This patch will consume the skbs instead and allow caller's to use kfree_skb. Signed-off-by: Mike Pattrick Link: https://bugzilla.redhat.com/show_bug.cgi?id=2109957 Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/openvswitch/datapath.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index a9868e97db45..b4e3db194140 100644 --- a/net/openvswitch/datapath.c +++ b/net/openvswitch/datapath.c @@ -526,8 +526,9 @@ static int queue_userspace_packet(struct datapath *dp, struct sk_buff *skb, out: if (err) skb_tx_error(skb); - kfree_skb(user_skb); - kfree_skb(nskb); + consume_skb(user_skb); + consume_skb(nskb); + return err; } -- 2.35.1