Re: [net-next][PATCH v4] dt-bindings: dsa: Add lan9303 yaml

Krzysztof Kozlowski
2022-10-18T22:35:10Z

On 17/10/2022 14:33, Jerry.Ray@microchip.com wrote:
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + reset-gpios:
>>> + description: Optional reset line
>>> + maxItems: 1
>>> +
>>> + reset-duration:
>>> + description: Reset duration in milliseconds
>>> + default: 200
>>
>> This is a friendly reminder during the review process.
>>
>> It seems my previous comments were not fully addressed. Maybe my
>> feedback got lost between the quotes, maybe you just forgot to apply it.
>> Please go back to the previous discussion and either implement all
>> requested changes or keep discussing them.
>>
>> Thank you.
>>
>
> I am documenting "what is" rather than what I think it should be. I
> would prefer there be a "-ms" suffix on the name, but that was not
> what was in the pre-existing code.
>
> I added the "default: 200" line and can add a "maxItems: 1", but begin
> getting errors when I attempt to further define this field as a
> uint32 type or anything like that.

There are no errors after adding proper type. However I cannot help you
for some unspecified code with unspecified warnings.

>
> And no, I'm not getting any warnings or errors from the dt_bindings_check.

Best regards,
Krzysztof