Re: [net-next][PATCH v4] dt-bindings: dsa: Add lan9303 yaml

Vladimir Oltean
2022-10-17T19:13:21Z

On Mon, Oct 17, 2022 at 06:51:57PM +0000, Jerry.Ray@microchip.com wrote:
> >> On 09/10/2022 18:22, Vladimir Oltean wrote:
> >> > On Sun, Oct 09, 2022 at 05:20:03PM +0200, Krzysztof Kozlowski wrote:
> >> >> On 09/10/2022 00:56, Vladimir Oltean wrote:
> >> >>>>
> >> >>>> +MICROCHIP LAN9303/LAN9354 ETHERNET SWITCH DRIVER
> >> >>>> +M: Jerry Ray <jerry.ray@microchip.com>
> >> >>>> +M: UNGLinuxDriver@microchip.com
> >> >>>> +L: netdev@vger.kernel.org
> >> >>>> +S: Maintained
> >> >>>> +F: Documentation/devicetree/bindings/net/dsa/microchip,lan9303.yaml
> >> >>>> +F: drivers/net/dsa/lan9303*
> >> >>>> +
> >> >>>
> >> >>> Separate patch please? Changes to the MAINTAINERS file get applied to
> >> >>> the "net" tree.
> >> >>
> >> >> This will also go via net tree, so there is no real need to split it.
> >> >
> >> > I meant exactly what I wrote, "net" tree as in the networking tree where
> >> > fixes to the current master branch are sent:
> >> > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git, or in
> >> > other words, not net-next.git where new features are sent:
> >> > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git
> >>
> >> Ah, but how it can go to fixes? It has invalid path (in the context of
> >> net-fixes) and it is not related to anything in the current cycle.
> >
> >Personally I'd split the patch into 2 pieces, the MAINTAINERS entry for
> >the drivers/net/dsa/lan9303* portion, plus the current .txt schema,
> >which goes to "net" right away, wait until the net tree gets merged back
> >into net-next (happens when submissions for net-next reopen), then add
> >the dt-bindings and rename the .txt schema from MAINTAINERS to .yaml.
> >
>
> If this patch should be flagged [net] rather than [net-next], please tell
> me. I'm looking to add content to the driver going forward and assumed
> net-next. Splitting the patch into 2 steps didn't make a lot of sense to
> me. Splitting the patch into 2 patches targeting 2 different repos makes
> even less sense. I assume the net MAINTAINERS list to be updated from
> net-next contributions on the next cycle.
>
> As I'm now outright deleting the lan9303.txt file, I'm getting the test bot
> error about also needing to change the rst file that references lan9303.txt.
> I'll do so in the next revision. The alternative is to drop the yaml, simply
> add to the old txt file, and be done with it. Your call.
>
> Regards,
> Jerry.

Ah, this is not a "my call" thing.

The portion I highlighted of the change you're making includes your name
into the output of $(./scripts/get_maintainer.pl drivers/net/dsa/lan9303-core.c).
In other words, you're voluntarily subscribing to the responsibility of
being a maintainer for the driver, getting emails from other developers,
reviewing patches. Furthermore, you also maintain the code in the stable
trees, hence your name also gets propagated there so people who use
those kernels can report problems to you.

The MAINTAINERS entry for lan9303 needs to go to the "net" tree, from
where it can be backported. This covers the driver + schema files as
they currently are. The change of the .txt to the .yaml schema then
comes on top of that (and on "net-next").