Re: [PATCH AUTOSEL 6.0 18/77] net: dsa: mv88e6xxx: Allow external SMI if serial

Vladimir Oltean
2022-10-10T11:54:55Z

On Sun, Oct 09, 2022 at 06:06:55PM -0400, Sasha Levin wrote:
> From: Marcus Carlberg <marcus.carlberg@axis.com>
>
> [ Upstream commit 8532c60efcc5b7b382006129b77aee2c19c43f15 ]
>
> p0_mode set to one of the supported serial mode should not prevent
> configuring the external SMI interface in
> mv88e6xxx_g2_scratch_gpio_set_smi. The current masking of the p0_mode
> only checks the first 2 bits. This results in switches supporting
> serial mode cannot setup external SMI on certain serial modes
> (Ex: 1000BASE-X and SGMII).
>
> Extend the mask of the p0_mode to include the reduced modes and
> serial modes as allowed modes for the external SMI interface.
>
> Signed-off-by: Marcus Carlberg <marcus.carlberg@axis.com>
> Link: https://lore.kernel.org/r/20220824093706.19049-1-marcus.carlberg@axis.com
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---

Not needed for stable kernels, please drop, thanks.