* [PATCH net-next] net: ngbe: Variables need to be initialized
@ 2022-10-09 7:09 Mengyuan Lou
2022-10-11 0:44 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Mengyuan Lou @ 2022-10-09 7:09 UTC (permalink / raw)
To: netdev; +Cc: jiawenwu, Mengyuan Lou
Variables need to be initialized in ngbe_shutdown()
Fix: commit <e79e40c83b9f> ("net: ngbe: Add build support for ngbe")
Signed-off-by: Mengyuan Lou <mengyuanlou@net-swift.com>
---
drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
index 7674cb6e5700..f754e53eb852 100644
--- a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
+++ b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
@@ -46,7 +46,7 @@ static void ngbe_dev_shutdown(struct pci_dev *pdev, bool *enable_wake)
static void ngbe_shutdown(struct pci_dev *pdev)
{
- bool wake;
+ bool wake = false;
ngbe_dev_shutdown(pdev, &wake);
--
2.37.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: ngbe: Variables need to be initialized
2022-10-09 7:09 [PATCH net-next] net: ngbe: Variables need to be initialized Mengyuan Lou
@ 2022-10-11 0:44 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2022-10-11 0:44 UTC (permalink / raw)
To: Mengyuan Lou; +Cc: netdev, jiawenwu
On Sun, 9 Oct 2022 15:09:12 +0800 Mengyuan Lou wrote:
> Variables need to be initialized in ngbe_shutdown()
> Fix: commit <e79e40c83b9f> ("net: ngbe: Add build support for ngbe")
Please look at the git history to find out what the correct form is for
the Fixes tag.
> Signed-off-by: Mengyuan Lou <mengyuanlou@net-swift.com>
> ---
> drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
> index 7674cb6e5700..f754e53eb852 100644
> --- a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
> +++ b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
> @@ -46,7 +46,7 @@ static void ngbe_dev_shutdown(struct pci_dev *pdev, bool *enable_wake)
>
> static void ngbe_shutdown(struct pci_dev *pdev)
> {
> - bool wake;
> + bool wake = false;
>
> ngbe_dev_shutdown(pdev, &wake);
The callee should make sure to always write to the variable, caller
init is a worse fix.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-11 0:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-09 7:09 [PATCH net-next] net: ngbe: Variables need to be initialized Mengyuan Lou
2022-10-11 0:44 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).