From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com
Subject: Re: [net-next PATCH] net: core: Add napi_complete_done tracepoint
Date: Mon, 10 Oct 2022 17:58:24 -0700 [thread overview]
Message-ID: <20221010175824.28c61c50@kernel.org> (raw)
In-Reply-To: <1665426094-88160-1-git-send-email-jdamato@fastly.com>
On Mon, 10 Oct 2022 11:21:34 -0700 Joe Damato wrote:
> Add a tracepoint to help debug napi_complete_done. Users who set
> defer_hard_irqs and the GRO timer can use this tracepoint to better
> understand what impact these options have when their NIC driver calls
> napi_complete_done.
>
> perf trace can be used to enable the tracepoint and the output can be
> examined to determine which settings should be adjusted.
Are you familiar with bpftrace, and it's ability to attach to kfunc
and kretfunc? We mostly add tracepoints to static functions which get
inlined these days.
next prev parent reply other threads:[~2022-10-11 0:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 18:21 [net-next PATCH] net: core: Add napi_complete_done tracepoint Joe Damato
2022-10-11 0:58 ` Jakub Kicinski [this message]
2022-10-11 1:01 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221010175824.28c61c50@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).