From: "Michael S. Tsirkin" <mst@redhat.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Menglong Dong <imagedong@tencent.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Petr Machata <petrm@nvidia.com>,
Guo Ren <guoren@linux.alibaba.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] net: drop netif_attrmask_next*()
Date: Fri, 14 Oct 2022 10:20:27 -0400 [thread overview]
Message-ID: <20221014102008-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20221013234349.1165689-1-yury.norov@gmail.com>
On Thu, Oct 13, 2022 at 04:43:44PM -0700, Yury Norov wrote:
> netif_attrmask_next_and() generates warnings if CONFIG_DEBUG_PER_CPU_MAPS
> is enabled. It is used in a single place. netif_attrmask_next() is not
> used at all. With some rework of __netif_set_xps_queue(), we can drop
> both functions, switch the code to well-tested bitmap API and fix the
> warning.
>
> v1: https://lore.kernel.org/netdev/20221002151702.3932770-1-yury.norov@gmail.com/T/
> v2: Fix missed bitmap initialization in patch #3.
does not seem to fix the warning
https://lore.kernel.org/r/0000000000001d91e205eafc3d01%40google.com
is it supposed to fix it?
> Yury Norov (4):
> net: move setup code out of mutex in __netif_set_xps_queue()
> net: merge XPS_CPU_DEV_MAPS_SIZE and XPS_RXQ_DEV_MAPS_SIZE macros
> net: initialize online_mask unconditionally in __netif_set_xps_queue()
> net: fix opencoded for_each_and_bit() in __netif_set_xps_queue()
>
> include/linux/netdevice.h | 53 ++-------------------------------------
> net/core/dev.c | 35 ++++++++++++++------------
> 2 files changed, 21 insertions(+), 67 deletions(-)
>
> --
> 2.34.1
prev parent reply other threads:[~2022-10-14 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 23:43 [PATCH v2 0/4] net: drop netif_attrmask_next*() Yury Norov
2022-10-13 23:43 ` [PATCH v2 1/4] net: move setup code out of mutex in __netif_set_xps_queue() Yury Norov
2022-10-13 23:43 ` [PATCH v2 2/4] net: merge XPS_CPU_DEV_MAPS_SIZE and XPS_RXQ_DEV_MAPS_SIZE macros Yury Norov
2022-10-13 23:43 ` [PATCH v2 3/4] net: initialize online_mask unconditionally in __netif_set_xps_queue() Yury Norov
2022-10-13 23:43 ` [PATCH v2 4/4] net: fix opencoded for_each_and_bit() " Yury Norov
2022-10-14 9:38 ` Michael S. Tsirkin
2022-10-14 14:20 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221014102008-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guoren@linux.alibaba.com \
--cc=imagedong@tencent.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).