From: Jakub Kicinski <kuba@kernel.org>
To: Yury Norov <yury.norov@gmail.com>
Cc: guoren@kernel.org, andriy.shevchenko@linux.intel.com,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
linux@rasmusvillemoes.dk, caraitto@google.com,
willemb@google.com, jonolson@google.com,
amritha.nambiar@intel.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Guo Ren <guoren@linux.alibaba.com>
Subject: Re: [PATCH V2 1/2] net: Fixup netif_attrmask_next_and warning
Date: Fri, 14 Oct 2022 11:03:30 -0700 [thread overview]
Message-ID: <20221014110330.044bbbf4@kernel.org> (raw)
In-Reply-To: <CAAH8bW_6uT7M_y7GEZSrzo1WJZfZ2j=UeZreXX9yHCEFqXNJzQ@mail.gmail.com>
On Fri, 14 Oct 2022 09:16:01 -0700 Yury Norov wrote:
> > We will not be merging a refactoring series into net to silence an
> > arguably over-eager warning. We need a minimal fix, Guo Ren's patches
> > seem to miss the mark so I reckon the best use of everyone's time is
> > to just drop the exposing patch and retry in -next 🤷
>
> If you prefer treating symptoms rather than the disease - I have nothing
> to add.
I don't, but we may consider different things to be "the disease".
Please do not insinuate that I don't care about fixing bugs.
What I can grok from the history and your commit messages is that
you want to catch people who pass what you consider invalid inputs
to the helpers, but nothing will crash/OOB access here, because
the helper double checks that the input is < nr_bits.
So it's a nice cleanup and refactoring, sure, but not an urgent fix
that needs to go to Linus ASAP.
If that's not what you're fixing please explain, I believe I already
asked you to clarify before. And the commit message aren't exactly
informative either.
next prev parent reply other threads:[~2022-10-14 18:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 3:04 [PATCH V2 0/2] net: Fixup cpu_mask usage guoren
2022-10-14 3:04 ` [PATCH V2 1/2] net: Fixup netif_attrmask_next_and warning guoren
2022-10-14 3:35 ` Jakub Kicinski
2022-10-14 3:39 ` Jakub Kicinski
2022-10-14 4:42 ` Yury Norov
2022-10-14 6:42 ` Guo Ren
2022-10-14 16:03 ` Jakub Kicinski
2022-10-14 16:16 ` Yury Norov
2022-10-14 18:03 ` Jakub Kicinski [this message]
2022-10-15 1:41 ` Guo Ren
2022-10-14 6:38 ` Guo Ren
2022-10-14 15:52 ` Jakub Kicinski
2022-10-15 1:38 ` Guo Ren
2022-10-14 10:00 ` Andy Shevchenko
2022-10-14 10:04 ` Guo Ren
2022-10-14 3:04 ` [PATCH V2 2/2] net: Fixup virtnet_set_affinity() cause cpumask warning guoren
2022-10-14 10:00 ` Andy Shevchenko
2022-10-14 10:04 ` Guo Ren
2022-10-17 1:58 ` Xuan Zhuo
2022-10-17 2:46 ` Guo Ren
2022-10-17 2:58 ` Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221014110330.044bbbf4@kernel.org \
--to=kuba@kernel.org \
--cc=amritha.nambiar@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=caraitto@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guoren@kernel.org \
--cc=guoren@linux.alibaba.com \
--cc=jonolson@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).