From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94945C433FE for ; Fri, 14 Oct 2022 18:03:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230410AbiJNSDn (ORCPT ); Fri, 14 Oct 2022 14:03:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230255AbiJNSDg (ORCPT ); Fri, 14 Oct 2022 14:03:36 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A96561B6C96; Fri, 14 Oct 2022 11:03:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5267AB82356; Fri, 14 Oct 2022 18:03:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B209C433C1; Fri, 14 Oct 2022 18:03:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665770612; bh=161vf/MZ9Uq3Rm1iKnGWQxZPlYkzch68bDKn9ElqWek=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dEJO7TBTXFVb84YJq4B8bg3pcBpDmPFaxL0rYF/0KgkmFCZBuC4Gc3hRO7qGu27Gn W5JOn0WbEzkrTeyQsaLUKUOBmkO9kOVhdj9DGaQ/i5QsAw3Uh2qW9B/a3cA2+1nGLK hKJgyv3Pcy2WTFs255fuRKk8132aBj2VOXerxamlWtB6MftmjBvYACjnqDkL0QwkJG tmZuUkKHtQKVgi3wBu+MiSL5JGCgevOvnlEzIZSWjT/mJ1pU4LzJWpQOAtZu7xGqo2 s/mh38esWmQGxSYEjMkUeOCJ1ciuEpUJrr1SXF6TpCl8mLcFsS2dDxaqaA7HOR7yQF zIKyw3oCmOz4Q== Date: Fri, 14 Oct 2022 11:03:30 -0700 From: Jakub Kicinski To: Yury Norov Cc: guoren@kernel.org, andriy.shevchenko@linux.intel.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, linux@rasmusvillemoes.dk, caraitto@google.com, willemb@google.com, jonolson@google.com, amritha.nambiar@intel.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Guo Ren Subject: Re: [PATCH V2 1/2] net: Fixup netif_attrmask_next_and warning Message-ID: <20221014110330.044bbbf4@kernel.org> In-Reply-To: References: <20221014030459.3272206-1-guoren@kernel.org> <20221014030459.3272206-2-guoren@kernel.org> <20221013203544.110a143c@kernel.org> <20221013203911.2705eccc@kernel.org> <20221014090311.392e0546@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 14 Oct 2022 09:16:01 -0700 Yury Norov wrote: > > We will not be merging a refactoring series into net to silence an > > arguably over-eager warning. We need a minimal fix, Guo Ren's patches > > seem to miss the mark so I reckon the best use of everyone's time is > > to just drop the exposing patch and retry in -next =F0=9F=A4=B7 =20 >=20 > If you prefer treating symptoms rather than the disease - I have nothing > to add. I don't, but we may consider different things to be "the disease". Please do not insinuate that I don't care about fixing bugs. What I can grok from the history and your commit messages is that=20 you want to catch people who pass what you consider invalid inputs=20 to the helpers, but nothing will crash/OOB access here, because=20 the helper double checks that the input is < nr_bits. So it's a nice cleanup and refactoring, sure, but not an urgent fix that needs to go to Linus ASAP. If that's not what you're fixing please explain, I believe I already asked you to clarify before. And the commit message aren't exactly informative either.