* [PATCH ipsec] xfrm: lwtunnel: squelch kernel warning in case XFRM encap type is not available
@ 2022-10-11 8:01 Eyal Birger
2022-10-11 9:00 ` Ido Schimmel
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Eyal Birger @ 2022-10-11 8:01 UTC (permalink / raw)
To: idosch, davem, edumazet, kuba, pabeni, steffen.klassert, herbert,
dsahern, contact, pablo, nicolas.dichtel, razor, daniel
Cc: netdev, Eyal Birger
Ido reported that a kernel warning [1] can be triggered from
user space when the kernel is compiled with CONFIG_MODULES=y and
CONFIG_XFRM=n when adding an xfrm encap type route, e.g:
$ ip route add 198.51.100.0/24 dev dummy1 encap xfrm if_id 1
Error: lwt encapsulation type not supported.
The reason for the warning is that the LWT infrastructure has an
autoloading feature which is meant only for encap types that don't
use a net device, which is not the case in xfrm encap.
Mute this warning for xfrm encap as there's no encap module to autoload
in this case.
[1]
WARNING: CPU: 3 PID: 2746262 at net/core/lwtunnel.c:57 lwtunnel_valid_encap_type+0x4f/0x120
[...]
Call Trace:
<TASK>
rtm_to_fib_config+0x211/0x350
inet_rtm_newroute+0x3a/0xa0
rtnetlink_rcv_msg+0x154/0x3c0
netlink_rcv_skb+0x49/0xf0
netlink_unicast+0x22f/0x350
netlink_sendmsg+0x208/0x440
____sys_sendmsg+0x21f/0x250
___sys_sendmsg+0x83/0xd0
__sys_sendmsg+0x54/0xa0
do_syscall_64+0x35/0x80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
Reported-by: Ido Schimmel <idosch@idosch.org>
Fixes: 2c2493b9da91 ("xfrm: lwtunnel: add lwtunnel support for xfrm interfaces in collect_md mode")
Signed-off-by: Eyal Birger <eyal.birger@gmail.com>
---
net/core/lwtunnel.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c
index 6fac2f0ef074..711cd3b4347a 100644
--- a/net/core/lwtunnel.c
+++ b/net/core/lwtunnel.c
@@ -48,9 +48,11 @@ static const char *lwtunnel_encap_str(enum lwtunnel_encap_types encap_type)
return "RPL";
case LWTUNNEL_ENCAP_IOAM6:
return "IOAM6";
+ case LWTUNNEL_ENCAP_XFRM:
+ /* module autoload not supported for encap type */
+ return NULL;
case LWTUNNEL_ENCAP_IP6:
case LWTUNNEL_ENCAP_IP:
- case LWTUNNEL_ENCAP_XFRM:
case LWTUNNEL_ENCAP_NONE:
case __LWTUNNEL_ENCAP_MAX:
/* should not have got here */
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH ipsec] xfrm: lwtunnel: squelch kernel warning in case XFRM encap type is not available
2022-10-11 8:01 [PATCH ipsec] xfrm: lwtunnel: squelch kernel warning in case XFRM encap type is not available Eyal Birger
@ 2022-10-11 9:00 ` Ido Schimmel
2022-10-11 9:07 ` Nikolay Aleksandrov
2022-10-14 13:38 ` Steffen Klassert
2 siblings, 0 replies; 4+ messages in thread
From: Ido Schimmel @ 2022-10-11 9:00 UTC (permalink / raw)
To: Eyal Birger
Cc: davem, edumazet, kuba, pabeni, steffen.klassert, herbert, dsahern,
contact, pablo, nicolas.dichtel, razor, daniel, netdev
On Tue, Oct 11, 2022 at 11:01:37AM +0300, Eyal Birger wrote:
> Ido reported that a kernel warning [1] can be triggered from
> user space when the kernel is compiled with CONFIG_MODULES=y and
> CONFIG_XFRM=n when adding an xfrm encap type route, e.g:
>
> $ ip route add 198.51.100.0/24 dev dummy1 encap xfrm if_id 1
> Error: lwt encapsulation type not supported.
>
> The reason for the warning is that the LWT infrastructure has an
> autoloading feature which is meant only for encap types that don't
> use a net device, which is not the case in xfrm encap.
>
> Mute this warning for xfrm encap as there's no encap module to autoload
> in this case.
[...]
>
> Reported-by: Ido Schimmel <idosch@idosch.org>
> Fixes: 2c2493b9da91 ("xfrm: lwtunnel: add lwtunnel support for xfrm interfaces in collect_md mode")
> Signed-off-by: Eyal Birger <eyal.birger@gmail.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH ipsec] xfrm: lwtunnel: squelch kernel warning in case XFRM encap type is not available
2022-10-11 8:01 [PATCH ipsec] xfrm: lwtunnel: squelch kernel warning in case XFRM encap type is not available Eyal Birger
2022-10-11 9:00 ` Ido Schimmel
@ 2022-10-11 9:07 ` Nikolay Aleksandrov
2022-10-14 13:38 ` Steffen Klassert
2 siblings, 0 replies; 4+ messages in thread
From: Nikolay Aleksandrov @ 2022-10-11 9:07 UTC (permalink / raw)
To: Eyal Birger, idosch, davem, edumazet, kuba, pabeni,
steffen.klassert, herbert, dsahern, contact, pablo,
nicolas.dichtel, daniel
Cc: netdev
On 11/10/2022 11:01, Eyal Birger wrote:
> Ido reported that a kernel warning [1] can be triggered from
> user space when the kernel is compiled with CONFIG_MODULES=y and
> CONFIG_XFRM=n when adding an xfrm encap type route, e.g:
>
> $ ip route add 198.51.100.0/24 dev dummy1 encap xfrm if_id 1
> Error: lwt encapsulation type not supported.
>
> The reason for the warning is that the LWT infrastructure has an
> autoloading feature which is meant only for encap types that don't
> use a net device, which is not the case in xfrm encap.
>
> Mute this warning for xfrm encap as there's no encap module to autoload
> in this case.
>
> [1]
> WARNING: CPU: 3 PID: 2746262 at net/core/lwtunnel.c:57 lwtunnel_valid_encap_type+0x4f/0x120
> [...]
> Call Trace:
> <TASK>
> rtm_to_fib_config+0x211/0x350
> inet_rtm_newroute+0x3a/0xa0
> rtnetlink_rcv_msg+0x154/0x3c0
> netlink_rcv_skb+0x49/0xf0
> netlink_unicast+0x22f/0x350
> netlink_sendmsg+0x208/0x440
> ____sys_sendmsg+0x21f/0x250
> ___sys_sendmsg+0x83/0xd0
> __sys_sendmsg+0x54/0xa0
> do_syscall_64+0x35/0x80
> entry_SYSCALL_64_after_hwframe+0x63/0xcd
>
> Reported-by: Ido Schimmel <idosch@idosch.org>
> Fixes: 2c2493b9da91 ("xfrm: lwtunnel: add lwtunnel support for xfrm interfaces in collect_md mode")
> Signed-off-by: Eyal Birger <eyal.birger@gmail.com>
> ---
> net/core/lwtunnel.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c
> index 6fac2f0ef074..711cd3b4347a 100644
> --- a/net/core/lwtunnel.c
> +++ b/net/core/lwtunnel.c
> @@ -48,9 +48,11 @@ static const char *lwtunnel_encap_str(enum lwtunnel_encap_types encap_type)
> return "RPL";
> case LWTUNNEL_ENCAP_IOAM6:
> return "IOAM6";
> + case LWTUNNEL_ENCAP_XFRM:
> + /* module autoload not supported for encap type */
> + return NULL;
> case LWTUNNEL_ENCAP_IP6:
> case LWTUNNEL_ENCAP_IP:
> - case LWTUNNEL_ENCAP_XFRM:
> case LWTUNNEL_ENCAP_NONE:
> case __LWTUNNEL_ENCAP_MAX:
> /* should not have got here */
Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH ipsec] xfrm: lwtunnel: squelch kernel warning in case XFRM encap type is not available
2022-10-11 8:01 [PATCH ipsec] xfrm: lwtunnel: squelch kernel warning in case XFRM encap type is not available Eyal Birger
2022-10-11 9:00 ` Ido Schimmel
2022-10-11 9:07 ` Nikolay Aleksandrov
@ 2022-10-14 13:38 ` Steffen Klassert
2 siblings, 0 replies; 4+ messages in thread
From: Steffen Klassert @ 2022-10-14 13:38 UTC (permalink / raw)
To: Eyal Birger
Cc: idosch, davem, edumazet, kuba, pabeni, herbert, dsahern, contact,
pablo, nicolas.dichtel, razor, daniel, netdev
On Tue, Oct 11, 2022 at 11:01:37AM +0300, Eyal Birger wrote:
> Ido reported that a kernel warning [1] can be triggered from
> user space when the kernel is compiled with CONFIG_MODULES=y and
> CONFIG_XFRM=n when adding an xfrm encap type route, e.g:
>
> $ ip route add 198.51.100.0/24 dev dummy1 encap xfrm if_id 1
> Error: lwt encapsulation type not supported.
>
> The reason for the warning is that the LWT infrastructure has an
> autoloading feature which is meant only for encap types that don't
> use a net device, which is not the case in xfrm encap.
>
> Mute this warning for xfrm encap as there's no encap module to autoload
> in this case.
>
> [1]
> WARNING: CPU: 3 PID: 2746262 at net/core/lwtunnel.c:57 lwtunnel_valid_encap_type+0x4f/0x120
> [...]
> Call Trace:
> <TASK>
> rtm_to_fib_config+0x211/0x350
> inet_rtm_newroute+0x3a/0xa0
> rtnetlink_rcv_msg+0x154/0x3c0
> netlink_rcv_skb+0x49/0xf0
> netlink_unicast+0x22f/0x350
> netlink_sendmsg+0x208/0x440
> ____sys_sendmsg+0x21f/0x250
> ___sys_sendmsg+0x83/0xd0
> __sys_sendmsg+0x54/0xa0
> do_syscall_64+0x35/0x80
> entry_SYSCALL_64_after_hwframe+0x63/0xcd
>
> Reported-by: Ido Schimmel <idosch@idosch.org>
> Fixes: 2c2493b9da91 ("xfrm: lwtunnel: add lwtunnel support for xfrm interfaces in collect_md mode")
> Signed-off-by: Eyal Birger <eyal.birger@gmail.com>
Applied, thanks a lot!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-14 13:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-11 8:01 [PATCH ipsec] xfrm: lwtunnel: squelch kernel warning in case XFRM encap type is not available Eyal Birger
2022-10-11 9:00 ` Ido Schimmel
2022-10-11 9:07 ` Nikolay Aleksandrov
2022-10-14 13:38 ` Steffen Klassert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).