From: Kees Cook <keescook@chromium.org>
To: Ruhl@www.outflux.net, Michael J <michael.j.ruhl@intel.com>
Cc: Kees Cook <keescook@chromium.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: [PATCH v3 0/2] igb: Proactively round up to kmalloc bucket size
Date: Tue, 18 Oct 2022 02:25:23 -0700 [thread overview]
Message-ID: <20221018092340.never.556-kees@kernel.org> (raw)
Hi,
In preparation for removing the "silently change allocation size"
users of ksize(), explicitly round up all q_vector allocations so that
allocations can be correctly compared to ksize().
Before that, fix a potential Use After Free under memory pressure.
Thanks,
-Kees
v3; split UAF fix from bucket rounding.
v2: https://lore.kernel.org/lkml/20220923202822.2667581-7-keescook@chromium.org/
Kees Cook (2):
igb: Do not free q_vector unless new one was allocated
igb: Proactively round up to kmalloc bucket size
drivers/net/ethernet/intel/igb/igb_main.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
--
2.34.1
next reply other threads:[~2022-10-18 9:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 9:25 Kees Cook [this message]
2022-10-18 9:25 ` [PATCH v3 1/2] igb: Do not free q_vector unless new one was allocated Kees Cook
2022-10-18 12:20 ` Ruhl, Michael J
2022-10-29 3:29 ` [Intel-wired-lan] " G, GurucharanX
2022-10-18 9:25 ` [PATCH v3 2/2] igb: Proactively round up to kmalloc bucket size Kees Cook
2022-10-29 3:17 ` Kees Cook
2022-10-31 20:42 ` Ruhl, Michael J
2022-11-01 21:37 ` Kees Cook
2022-11-02 14:12 ` Ruhl, Michael J
2022-10-29 3:30 ` [Intel-wired-lan] " G, GurucharanX
2022-10-18 10:09 ` [PATCH v3 0/2] " Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018092340.never.556-kees@kernel.org \
--to=keescook@chromium.org \
--cc=Ruhl@www.outflux.net \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.j.ruhl@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).