From: Jakub Kicinski <kuba@kernel.org>
To: Nick Child <nnac123@linux.ibm.com>
Cc: netdev@vger.kernel.org, nick.child@ibm.com
Subject: Re: [PATCH net-next] ibmvnic: Free rwi on reset success
Date: Tue, 18 Oct 2022 11:45:02 -0700 [thread overview]
Message-ID: <20221018114502.1d976043@kernel.org> (raw)
In-Reply-To: <20221017151516.45430-1-nnac123@linux.ibm.com>
On Mon, 17 Oct 2022 10:15:16 -0500 Nick Child wrote:
> Subject: [PATCH net-next] ibmvnic: Free rwi on reset success
Why net-next? it's a fix, right? it should go to Linus in the current
release cycle, i.e. the next -rc release.
Please make sure to CC the authors of the change under Fixes, and
the maintainers of the driver. ./scripts/get_maintainer is your friend.
> Free the rwi structure in the event that the last rwi in the list
> processed successfully. The logic in commit 4f408e1fa6e1 ("ibmvnic:
> retry reset if there are no other resets") introduces an issue that
> results in a 32 byte memory leak whenever the last rwi in the list
> gets processed.
>
> Fixes: 4f408e1fa6e1 ("ibmvnic: retry reset if there are no other resets")
> Signed-off-by: Nick Child <nnac123@linux.ibm.com>
next prev parent reply other threads:[~2022-10-18 18:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 15:15 [PATCH net-next] ibmvnic: Free rwi on reset success Nick Child
2022-10-18 18:45 ` Jakub Kicinski [this message]
2022-10-18 20:01 ` Nick Child
2022-10-18 20:06 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018114502.1d976043@kernel.org \
--to=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nick.child@ibm.com \
--cc=nnac123@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).