From: Jakub Kicinski <kuba@kernel.org>
To: Martin KaFai Lau <martin.lau@linux.dev>
Cc: wangyufen <wangyufen@huawei.com>,
Lina Wang <lina.wang@mediatek.com>,
bpf@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, deso@posteo.net, netdev@vger.kernel.org
Subject: Re: [net 1/2] selftests/net: fix opening object file failed
Date: Tue, 18 Oct 2022 18:53:11 -0700 [thread overview]
Message-ID: <20221018185311.568a581e@kernel.org> (raw)
In-Reply-To: <f3dd8b70-f44b-128a-42a5-98135d457ffd@linux.dev>
On Tue, 18 Oct 2022 18:30:07 -0700 Martin KaFai Lau wrote:
> > Can we move the programs and create a dependency from them back
> > to networking? Perhaps shared components like udpgso_* need to live
> > under tools/net so they can be easily "depended on"?
> >
> > Either that or they need to switch to a different traffic generator for
> > the BPF test, cause there's more networking selftests using the UDP
> > generators :(
>
> All (at least most) of the selftests/bpf/test_prog's tests generate its own
> traffic for unit test purpose such that each test is self contained. The
> udpgro_frglist test should do the same in selftests/bpf/test_prog (meaning the
> test itself should generate its own testing traffic). Also, it does not look
> like it is actually using udpgso_bench_* to do benchmarking.
Sure, copy & paste of the right snippet will work too.
Shouldn't be a lot of code to send and receive a few UDP GSOs.
next prev parent reply other threads:[~2022-10-19 1:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 9:57 [net 0/2] some fixes for selftest/net Wang Yufen
2022-10-11 9:57 ` [net 1/2] selftests/net: fix opening object file failed Wang Yufen
2022-10-13 1:51 ` Martin KaFai Lau
2022-10-18 2:57 ` wangyufen
2022-10-18 9:50 ` wangyufen
2022-10-18 16:26 ` Alexei Starovoitov
2022-10-18 18:00 ` Jakub Kicinski
2022-10-19 1:30 ` Martin KaFai Lau
2022-10-19 1:53 ` Jakub Kicinski [this message]
2022-10-11 9:57 ` [net 2/2] selftests/net: fix missing xdp_dummy Wang Yufen
2022-10-11 16:27 ` Daniel Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018185311.568a581e@kernel.org \
--to=kuba@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=deso@posteo.net \
--cc=edumazet@google.com \
--cc=lina.wang@mediatek.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wangyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).