From: Jakub Kicinski <kuba@kernel.org>
To: Vadim Fedorenko <vfedorenko@novek.ru>
Cc: Richard Cochran <richardcochran@gmail.com>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
netdev@vger.kernel.org, Vadim Fedorenko <vadfed@fb.com>,
Charles Parent <charles.parent@orolia2s.com>
Subject: Re: [PATCH net-next v3 2/5] ptp: ocp: add Orolia timecard support
Date: Tue, 18 Oct 2022 19:47:32 -0700 [thread overview]
Message-ID: <20221018194732.16f7d413@kernel.org> (raw)
In-Reply-To: <20221018090122.3361-3-vfedorenko@novek.ru>
On Tue, 18 Oct 2022 12:01:19 +0300 Vadim Fedorenko wrote:
> From: Vadim Fedorenko <vadfed@fb.com>
>
> This brings in the Orolia timecard support from the GitHub repository.
> The card uses different drivers to provide access to i2c EEPROM and
> firmware SPI flash. And it also has a bit different EEPROM map, but
> other parts of the code are the same and could be reused.
> +static const struct ocp_attr_group art_timecard_groups[];
> +static const struct ocp_sma_op ocp_art_sma_op;
Clang is not on board:
drivers/ptp/ptp_ocp.c:384:32: warning: tentative definition of variable with internal linkage has incomplete non-array type 'const struct ocp_sma_op' [-Wtentative-definition-incomplete-type]
static const struct ocp_sma_op ocp_art_sma_op;
^
drivers/ptp/ptp_ocp.c:349:15: note: forward declaration of 'struct ocp_sma_op'
const struct ocp_sma_op *sma_op;
^
You may need to throw an extern in there.
Is it not possible to just order things correctly in the first place?
Is there a dependency cycle?
next prev parent reply other threads:[~2022-10-19 2:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 9:01 [PATCH net-next v3 0/5] ptp: ocp: add support for Orolia ART-CARD Vadim Fedorenko
2022-10-18 9:01 ` [PATCH net-next v3 1/5] ptp: ocp: upgrade serial line information Vadim Fedorenko
2022-10-18 9:01 ` [PATCH net-next v3 2/5] ptp: ocp: add Orolia timecard support Vadim Fedorenko
2022-10-19 2:47 ` Jakub Kicinski [this message]
2022-10-19 18:10 ` Vadim Fedorenko
2022-10-20 1:14 ` kernel test robot
2022-10-18 9:01 ` [PATCH net-next v3 3/5] ptp: ocp: add serial port of mRO50 MAC on ART card Vadim Fedorenko
2022-10-18 9:01 ` [PATCH net-next v3 4/5] ptp: ocp: expose config and temperature for " Vadim Fedorenko
2022-10-18 9:01 ` [PATCH net-next v3 5/5] ptp: ocp: remove flash image header check fallback Vadim Fedorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018194732.16f7d413@kernel.org \
--to=kuba@kernel.org \
--cc=charles.parent@orolia2s.com \
--cc=jonathan.lemon@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=vadfed@fb.com \
--cc=vfedorenko@novek.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).