From: Vladimir Oltean <olteanv@gmail.com>
To: Sergei Antonov <saproj@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v3 net] net: ftmac100: support frames with DSA tag
Date: Wed, 19 Oct 2022 17:02:39 +0300 [thread overview]
Message-ID: <20221019140239.hboqna4lugwmnwph@skbuf> (raw)
In-Reply-To: <CABikg9ziSUJ5_DWro_TgCDMRYmgBfQNaEjKrCFQjaoUhkwRZOg@mail.gmail.com>
On Wed, Oct 19, 2022 at 04:57:05PM +0300, Sergei Antonov wrote:
> > Which VLAN tag do you mean? Earlier you mentioned a tail tag as can be
> > seen and parsed by net/dsa/tag_trailer.c. Don't conflate the two, one
> > has nothing to do with the other.
>
> I used print_hex_dump_bytes() in the ftmac100 driver to see what is
> inside the received packet. Here is how the 1518 byte long packet
> looks:
> 6 bytes - dst MAC
> 6 bytes - src MAC
> 4 bytes - 08 00 45 10
> 2 bytes - 0x5dc - data length (1500)
> 1500 bytes - data
>
> I am not sure what is the proper name for these 08 00 45 10 bytes.
> Tell me the correct name to use in the next version of the patch :).
Humm, how about IPv4 EtherType (08 00) plus the first 2 bytes from the
IPv4 header? 802.1Q EtherType is 0x8100.
next prev parent reply other threads:[~2022-10-19 14:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 15:57 [PATCH v3 net] net: ftmac100: support frames with DSA tag Sergei Antonov
2022-10-17 15:55 ` Vladimir Oltean
2022-10-19 13:57 ` Sergei Antonov
2022-10-19 14:02 ` Vladimir Oltean [this message]
2022-10-19 16:19 ` Sergei Antonov
2022-10-19 16:31 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221019140239.hboqna4lugwmnwph@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saproj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox