From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id E535FC433FE
	for <netdev@archiver.kernel.org>; Wed, 19 Oct 2022 22:44:31 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229569AbiJSWoa (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Wed, 19 Oct 2022 18:44:30 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54458 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229552AbiJSWo2 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 19 Oct 2022 18:44:28 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BA5C25E1
        for <netdev@vger.kernel.org>; Wed, 19 Oct 2022 15:44:22 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id 179DD619C2
        for <netdev@vger.kernel.org>; Wed, 19 Oct 2022 22:44:22 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06504C433C1;
        Wed, 19 Oct 2022 22:44:20 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1666219461;
        bh=DEQVncjl7ccQ5RwZ9RHKdQqCAk9LSiNde965NC095TU=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=p1xFarunbxxsZ4zWMXhk1Zt5JwVIWwwoFMxgRqvYzZEgaRpfYdupyrSZXPKpGVfb2
         HmdWgkbT+fV1+V6WpGS4OAeV5/JI60O48jYzA1yal67eFotuhjeGGZZRHcyVeuK/yw
         UkkwawZhJE/uTfBL8VTgyugd69xaLxIfldgvehSV4TvGjLquv59gp936ep2BgrwA/p
         ntyvC5hFn4kyTbVHQ7Es6rMoUe6X+4A3ls+/jdIZBZxLRFh9FVp+O6BtEjcWcHtUDB
         s3trPuen+gKb0gYHtkqmWccu9Y5goP1d2aqY8q0KVdadJEW0R/JmaLhQKDHMGVPETP
         zZ67c6N6rn4cw==
Date:   Wed, 19 Oct 2022 15:44:20 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Leon Romanovsky <leon@kernel.org>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Leon Romanovsky <leonro@nvidia.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Emeel Hakim <ehakim@nvidia.com>,
        Eric Dumazet <edumazet@google.com>, netdev@vger.kernel.org,
        Paolo Abeni <pabeni@redhat.com>, Raed Salem <raeds@nvidia.com>,
        Saeed Mahameed <saeedm@nvidia.com>,
        Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [PATCH RESEND net] net/mlx5e: Cleanup MACsec uninitialization
 routine
Message-ID: <20221019154420.0274374a@kernel.org>
In-Reply-To: <4bd5c6655c5970ac30adb254a1f09f4f5e992158.1666159448.git.leonro@nvidia.com>
References: <4bd5c6655c5970ac30adb254a1f09f4f5e992158.1666159448.git.leonro@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Wed, 19 Oct 2022 09:06:43 +0300 Leon Romanovsky wrote:
> The mlx5e_macsec_cleanup() routine has pointer dereferencing if mlx5 device
                                        ^
                                NULL? _/

> doesn't support MACsec (priv->macsec will be NULL) together with useless

s/together with/. While at it delete/

> comment line, assignment and extra blank lines.