Netdev List
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Sergei Antonov <saproj@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, andrew@lunn.ch
Subject: Re: [PATCH v4 net-next] net: ftmac100: support mtu > 1500
Date: Wed, 19 Oct 2022 21:42:03 +0300	[thread overview]
Message-ID: <20221019184203.4ywx3ighj72hjbqz@skbuf> (raw)
In-Reply-To: <CABikg9xBT-CPhuwAiQm3KLf8PTsWRNztryPpeP2Xb6SFzXDO0A@mail.gmail.com>

On Wed, Oct 19, 2022 at 09:36:21PM +0300, Sergei Antonov wrote:
> On Wed, 19 Oct 2022 at 19:55, Vladimir Oltean <olteanv@gmail.com> wrote:
> >
> > On Wed, Oct 19, 2022 at 07:20:58PM +0300, Sergei Antonov wrote:
> > > The ftmac100 controller considers some packets FTL (frame
> > > too long) and drops them. An example of a dropped packet:
> > > 6 bytes - dst MAC
> > > 6 bytes - src MAC
> > > 2 bytes - EtherType IPv4 (0800)
> > > 1504 bytes - IPv4 packet
> >
> > Why do you insist writing these confusing messages?
> 
> Yes, I see now it is not good. And I have a question.
> By comparing the packet sent from the sending computer and the packet
> received by ftmac100 I found that 4 bytes get appended to the packet:
> 80 02 00 00
> I guess it is what 88E6060 switch adds. But it is not 0x8100. Then
> what it is? I looked into include/linux/if_vlan.h but still don't get
> it.

See trailer_rcv() in net/dsa/tag_trailer.c. The switch is telling you
that this is a packet received from source port 2 via a tail tag
(trailer, i.e. added to the end of the packet, meaning right before the FCS).
I know that mv88e6060 uses this tagging protocol because this is what
mv88e6060_get_tag_protocol() returns. Still nothing to do with if_vlan.h.

Also see if Documentation/networking/dsa/dsa.rst answers some of the
other questions.

  reply	other threads:[~2022-10-19 18:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-19 16:20 [PATCH v4 net-next] net: ftmac100: support mtu > 1500 Sergei Antonov
2022-10-19 16:25 ` Sergei Antonov
2022-10-19 16:55 ` Vladimir Oltean
2022-10-19 18:36   ` Sergei Antonov
2022-10-19 18:42     ` Vladimir Oltean [this message]
2022-10-24 15:50       ` Sergei Antonov
2022-10-24 16:09         ` Andrew Lunn
2022-10-24 16:21           ` Vladimir Oltean
2022-10-24 16:24             ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221019184203.4ywx3ighj72hjbqz@skbuf \
    --to=olteanv@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saproj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox