From: Jakub Kicinski <kuba@kernel.org>
To: Xin Long <lucien.xin@gmail.com>
Cc: syzbot <syzbot+81c4b4bbba6eea2cfcae@syzkaller.appspotmail.com>,
andrew@lunn.ch, bagasdotme@gmail.com, davem@davemloft.net,
edumazet@google.com, linux-kernel@vger.kernel.org,
linux@rempel-privat.de, lkp@intel.com, netdev@vger.kernel.org,
pabeni@redhat.com, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] general protection fault in pse_prepare_data
Date: Wed, 19 Oct 2022 20:04:19 -0700 [thread overview]
Message-ID: <20221019200419.45f2c063@kernel.org> (raw)
In-Reply-To: <CADvbK_cXfDVFJ-eo-+uqXXPT1Xt7qf4bg0Cu6U5Zg7TCLeqoUw@mail.gmail.com>
On Wed, 19 Oct 2022 22:25:47 -0400 Xin Long wrote:
> > Yeah, looking at ethtool internals - info can be NULL :(
> It seems that eeprom_prepare_data() doesn't check info before
> accessing info->extack either.
Good catch, looks like that one dumps as well!
Perhaps we should require netdevsim support for all new commands
going forward :S Otherwise this code is hard for syzbot to exercise.
prev parent reply other threads:[~2022-10-20 3:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 11:26 [syzbot] general protection fault in pse_prepare_data syzbot
2022-10-19 22:30 ` Jakub Kicinski
2022-10-20 2:25 ` Xin Long
2022-10-20 3:04 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221019200419.45f2c063@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=bagasdotme@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=lkp@intel.com \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+81c4b4bbba6eea2cfcae@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).