[PATCH net] MAINTAINERS: add keyword match on PTP

[PATCH net] MAINTAINERS: add keyword match on PTP

[Jakub Kicinski]

Most of PTP drivers live under ethernet and we have to keep
telling people to CC the PTP maintainers. Let's try a keyword
match, we can refine as we go if it causes false positives.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5c6ce094e55e..ba8ed738494f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16673,6 +16673,7 @@ F:	Documentation/driver-api/ptp.rst
 F:	drivers/net/phy/dp83640*
 F:	drivers/ptp/*
 F:	include/linux/ptp_cl*
+K:	(?:\b|_)ptp(?:\b|_)
 
 PTP VIRTUAL CLOCK SUPPORT
 M:	Yangbo Lu <yangbo.lu@nxp.com>
-- 
2.37.3

Re: [PATCH net] MAINTAINERS: add keyword match on PTP

[Richard Cochran]

On Wed, Oct 19, 2022 at 07:19:13PM -0700, Jakub Kicinski wrote:
> Most of PTP drivers live under ethernet and we have to keep
> telling people to CC the PTP maintainers. Let's try a keyword
> match, we can refine as we go if it causes false positives.

This is great, thanks!

Richard

Re: [PATCH net] MAINTAINERS: add keyword match on PTP

[Leon Romanovsky]

On Wed, Oct 19, 2022 at 07:19:13PM -0700, Jakub Kicinski wrote:
> Most of PTP drivers live under ethernet and we have to keep
> telling people to CC the PTP maintainers. Let's try a keyword
> match, we can refine as we go if it causes false positives.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5c6ce094e55e..ba8ed738494f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16673,6 +16673,7 @@ F:	Documentation/driver-api/ptp.rst
>  F:	drivers/net/phy/dp83640*
>  F:	drivers/ptp/*
>  F:	include/linux/ptp_cl*
> +K:	(?:\b|_)ptp(?:\b|_)

I tried it with grep (maybe it is wrong) and it finds only files with
underscores.

➜  kernel git:(m/xfrm-latest) tree | grep -E "(?:\b|_)ptp(?:\b|_)"
│   │   │   │   │   ├── ice_ptp_consts.h
│   │   │   │   │   ├── ice_ptp_hw.c
│   │   │   │   │   ├── ice_ptp_hw.h

And this is as it is written in MAINTAINERS without "_".

➜  kernel git:(m/xfrm-latest) tree | grep -E "\bptp\b"
│   │       ├── sysfs-ptp
│   │   │   │   ├── intel,ixp46x-ptp-timer.yaml
│   │   │   ├── ptp
│   │   │   │   ├── brcm,ptp-dte.txt
│   │   │   │   ├── ptp-idt82p33.yaml
│   │   │   │   ├── ptp-idtcm.yaml
│   │   │   │   ├── ptp-ines.txt
│   │   │   │   ├── ptp-qoriq.txt
│   │   ├── ptp.rst
│   │   │   │   ├── ptp.c
│   │   │   │   ├── ptp.h
│   │   │   │       └── xgbe-ptp.c
│   │   │   │   │   ├── dpaa2-ptp.c
│   │   │   │   │   ├── dpaa2-ptp.h
│   │   │   │   │   ├── ptp.c
│   │   │   │   │   │   ├── ptp.c
│   │   │   │   │   │   ├── ptp.h
│   │   │   │   │       │   ├── ptp.c
│   │   │   │   │       │   ├── ptp.h
│   │   │   │   ├── ptp.c
│   │   │   │   ├── ptp.h
│   │   │   │   │   ├── ptp.c
│   │   │   │   │   ├── ptp.h
│   │   │   ├── bcm-phy-ptp.c

Should I try it differently?

Thanks

>  
>  PTP VIRTUAL CLOCK SUPPORT
>  M:	Yangbo Lu <yangbo.lu@nxp.com>
> -- 
> 2.37.3
> 

Re: [PATCH net] MAINTAINERS: add keyword match on PTP

[Leon Romanovsky]

On Thu, Oct 20, 2022 at 08:51:46AM +0300, Leon Romanovsky wrote:
> On Wed, Oct 19, 2022 at 07:19:13PM -0700, Jakub Kicinski wrote:
> > Most of PTP drivers live under ethernet and we have to keep
> > telling people to CC the PTP maintainers. Let's try a keyword
> > match, we can refine as we go if it causes false positives.
> > 
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> > ---
> >  MAINTAINERS | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 5c6ce094e55e..ba8ed738494f 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -16673,6 +16673,7 @@ F:	Documentation/driver-api/ptp.rst
> >  F:	drivers/net/phy/dp83640*
> >  F:	drivers/ptp/*
> >  F:	include/linux/ptp_cl*
> > +K:	(?:\b|_)ptp(?:\b|_)
> 
> I tried it with grep (maybe it is wrong) and it finds only files with
> underscores.
> 
> ➜  kernel git:(m/xfrm-latest) tree | grep -E "(?:\b|_)ptp(?:\b|_)"
> │   │   │   │   │   ├── ice_ptp_consts.h
> │   │   │   │   │   ├── ice_ptp_hw.c
> │   │   │   │   │   ├── ice_ptp_hw.h
> 
> And this is as it is written in MAINTAINERS without "_".
> 
> ➜  kernel git:(m/xfrm-latest) tree | grep -E "\bptp\b"
> │   │       ├── sysfs-ptp
> │   │   │   │   ├── intel,ixp46x-ptp-timer.yaml
> │   │   │   ├── ptp
> │   │   │   │   ├── brcm,ptp-dte.txt
> │   │   │   │   ├── ptp-idt82p33.yaml
> │   │   │   │   ├── ptp-idtcm.yaml
> │   │   │   │   ├── ptp-ines.txt
> │   │   │   │   ├── ptp-qoriq.txt
> │   │   ├── ptp.rst
> │   │   │   │   ├── ptp.c
> │   │   │   │   ├── ptp.h
> │   │   │   │       └── xgbe-ptp.c
> │   │   │   │   │   ├── dpaa2-ptp.c
> │   │   │   │   │   ├── dpaa2-ptp.h
> │   │   │   │   │   ├── ptp.c
> │   │   │   │   │   │   ├── ptp.c
> │   │   │   │   │   │   ├── ptp.h
> │   │   │   │   │       │   ├── ptp.c
> │   │   │   │   │       │   ├── ptp.h
> │   │   │   │   ├── ptp.c
> │   │   │   │   ├── ptp.h
> │   │   │   │   │   ├── ptp.c
> │   │   │   │   │   ├── ptp.h
> │   │   │   ├── bcm-phy-ptp.c
> 
> Should I try it differently?

And maybe "K: ptp" will be even better.

> 
> Thanks
> 
> >  
> >  PTP VIRTUAL CLOCK SUPPORT
> >  M:	Yangbo Lu <yangbo.lu@nxp.com>
> > -- 
> > 2.37.3
> > 

Re: [PATCH net] MAINTAINERS: add keyword match on PTP

[Jakub Kicinski]

On Thu, 20 Oct 2022 09:12:20 +0300 Leon Romanovsky wrote:
> > Should I try it differently?  

I think these are supposed to be Perl regexps:

	K: *Content regex* (perl extended) pattern match in a patch or file.

IOW try grep -P rather than grep -E.

> And maybe "K: ptp" will be even better.

That may be too wide, for instance it matches PPTP :(

Re: [PATCH net] MAINTAINERS: add keyword match on PTP

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Wed, 19 Oct 2022 19:19:13 -0700 you wrote:
> Most of PTP drivers live under ethernet and we have to keep
> telling people to CC the PTP maintainers. Let's try a keyword
> match, we can refine as we go if it causes false positives.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)

Here is the summary with links:
  - [net] MAINTAINERS: add keyword match on PTP
    https://git.kernel.org/netdev/net/c/4d814b329a4d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH net] MAINTAINERS: add keyword match on PTP

[Leon Romanovsky]

On Thu, Oct 20, 2022 at 10:56:28AM -0700, Jakub Kicinski wrote:
> On Thu, 20 Oct 2022 09:12:20 +0300 Leon Romanovsky wrote:
> > > Should I try it differently?  
> 
> I think these are supposed to be Perl regexps:
> 
> 	K: *Content regex* (perl extended) pattern match in a patch or file.
> 
> IOW try grep -P rather than grep -E.

Tried now, it works, thanks.

> 
> > And maybe "K: ptp" will be even better.
> 
> That may be too wide, for instance it matches PPTP :(