From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 593F0C4332F for ; Thu, 20 Oct 2022 14:11:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229919AbiJTOLO (ORCPT ); Thu, 20 Oct 2022 10:11:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229460AbiJTOLM (ORCPT ); Thu, 20 Oct 2022 10:11:12 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D32B170B77; Thu, 20 Oct 2022 07:11:11 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id r17so47672146eja.7; Thu, 20 Oct 2022 07:11:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lmwon3whKue/CVr8WrW952+rwBDr0RPAb1kYusMk964=; b=h80IgPyAct7MK5zRLczRsF/1fG3PBVUcnjpRONux/l7QMniZAgQZF7KLJ/b8Xb57nV eNAHIneSfPVRYfQcjBU3UbTc8pcRnTz9EZFVSA2Wme8B885eczCZhwaStsn2GzrZ+2Yh enoURpRTuzQsVnhi3X9wa5HCqzTl9P29ZaZd/6G3Bqi5N6nREPYEZxVqPLjXeaVZq0Ps fqwmyJ29Jjtsc72JKjktuIL9cU5LUimNJgQZFh2PNUR3x6l8gj7g9UKGLd4ZQxSomeBp sbCQCd8BswmIENyTJcTrmwGkm6PzlkR13ILiaHEOGbZjT+4lhpa2zKxGvQ6fu5DKQUUB em4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lmwon3whKue/CVr8WrW952+rwBDr0RPAb1kYusMk964=; b=KB991ka1v00FADRhHBeNS+LRvDsWvYR2tjajeBCpXYz1A11W44eIFzsXFs5F4QGcVc czXrk+kENlIO0WVTs8mmo1iOwrnePssU0MgaG3c70Ia+hBfWevESFuFpMfpZoKsRBOg7 4F2tyR2pnss0EzXiPQhFnvHYqC8X7yAkwPLVj5gD44BD2G/SoAsmt3JZj0TNRqw8MNbS D7VFZGrPf+8D3y1CAJ6YvRdyaMXQ6SMEexbTgRsORyWBoNn7CZcVNnO/kHnFi337Bhxv ZcaXAzV4x3SV9cY6Sjvze1KkNDrpMeqN90HOJky0MZOYCeEtOYmNMleNyXYfnhaecBrD sr2g== X-Gm-Message-State: ACrzQf1+zXGVj1KwUlx4nyrNJrP6H0h3vhtPeoFaPo6qRUCopWXrnB1z sIFE6botQASoVo3mlYA6m94= X-Google-Smtp-Source: AMsMyM57aHXW/RGGiBVsB52ziBQZJfs8YnrGc+aSU1SEGc3QC4xsLDheavS6ccxJp971i10kW+FYgA== X-Received: by 2002:a17:906:a4a:b0:782:686d:a1b6 with SMTP id x10-20020a1709060a4a00b00782686da1b6mr11023934ejf.232.1666275069320; Thu, 20 Oct 2022 07:11:09 -0700 (PDT) Received: from skbuf ([188.27.184.197]) by smtp.gmail.com with ESMTPSA id l17-20020a056402345100b0045cba869e84sm12232510edc.26.2022.10.20.07.11.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 07:11:08 -0700 (PDT) Date: Thu, 20 Oct 2022 17:11:04 +0300 From: Vladimir Oltean To: Ido Schimmel Cc: "Hans J. Schultz" , davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Russell King , Christian Marangi , Daniel Borkmann , Yuwei Wang , Petr Machata , Florent Fourcot , Hans Schultz , Joachim Wiberg , Amit Cohen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v8 net-next 05/12] net: dsa: propagate the locked flag down through the DSA layer Message-ID: <20221020141104.7h7kpau6cnpfqvh4@skbuf> References: <20221018165619.134535-1-netdev@kapio-technology.com> <20221018165619.134535-1-netdev@kapio-technology.com> <20221018165619.134535-6-netdev@kapio-technology.com> <20221018165619.134535-6-netdev@kapio-technology.com> <20221020130224.6ralzvteoxfdwseb@skbuf> <20221020133506.76wroc7owpwjzrkg@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Oct 20, 2022 at 04:57:35PM +0300, Ido Schimmel wrote: > > Right now this packet isn't generated, right? > > Right. We don't support BR_PORT_LOCKED so these checks are not currently > enabled in hardware. To be clear, only packets received via locked ports > are able to trigger the check. You mean BR_PORT_MAB, not BR_PORT_LOCKED, right? AFAIU, "locked" means drop unknown MAC SA, "mab" means "install BR_FDB_LOCKED entry on port" (and also maybe still drop, if "locked" is also set on port). Sad there isn't any good documentation about these flags in the patches that Hans is proposing.