From: Stephen Hemminger <stephen@networkplumber.org>
To: Hao Lan <lanhao@huawei.com>
Cc: <lipeng321@huawei.com>, <shenjian15@huawei.com>,
<huangguangbin2@huawei.com>, <chenjunxin1@huawei.com>,
<netdev@vger.kernel.org>, <dsahern@kernel.org>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>
Subject: Re: [PATCH iproute2] dcb: unblock mnl_socket_recvfrom if not message received
Date: Thu, 20 Oct 2022 15:59:36 -0700 [thread overview]
Message-ID: <20221020155936.0868a482@hermes.local> (raw)
In-Reply-To: <20221019012008.11322-1-lanhao@huawei.com>
On Wed, 19 Oct 2022 09:20:08 +0800
Hao Lan <lanhao@huawei.com> wrote:
> From: Junxin Chen <chenjunxin1@huawei.com>
>
> Currently, the dcb command sinks to the kernel through the netlink
> to obtain information. However, if the kernel fails to obtain infor-
> mation or is not processed, the dcb command is suspended.
>
> For example, if we don't implement dcbnl_ops->ieee_getpfc in the
> kernel, the command "dcb pfc show dev eth1" will be stuck and subsequent
> commands cannot be executed.
>
> This patch adds the NLM_F_ACK flag to the netlink in mnlu_msg_prepare
> to ensure that the kernel responds to user requests.
>
> After the problem is solved, the execution result is as follows:
> $ dcb pfc show dev eth1
> Attribute not found: Success
>
> Fixes: 67033d1c1c ("Add skeleton of a new tool, dcb")
> Signed-off-by: Junxin Chen <chenjunxin1@huawei.com>
Applied, fixed these two checkpatch warnings in original submission.
WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: 67033d1c1c8a ("Add skeleton of a new tool, dcb")'
#74:
Fixes: 67033d1c1c ("Add skeleton of a new tool, dcb")
WARNING: line length of 101 exceeds 100 columns
#89: FILE: dcb/dcb.c:159:
+ nlh = mnlu_msg_prepare(dcb->buf, nlmsg_type, NLM_F_REQUEST | NLM_F_ACK, &dcbm, sizeof(dcbm));
total: 0 errors, 2 warnings, 8 lines checked
next prev parent reply other threads:[~2022-10-20 22:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 1:20 [PATCH iproute2] dcb: unblock mnl_socket_recvfrom if not message received Hao Lan
2022-10-20 13:23 ` David Ahern
2022-10-20 22:59 ` Stephen Hemminger [this message]
2022-12-20 13:34 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020155936.0868a482@hermes.local \
--to=stephen@networkplumber.org \
--cc=chenjunxin1@huawei.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=huangguangbin2@huawei.com \
--cc=kuba@kernel.org \
--cc=lanhao@huawei.com \
--cc=lipeng321@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenjian15@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).