* [PATCH net] ethtool: eeprom: fix null-deref on genl_info in dump
@ 2022-10-21 14:22 Xin Long
2022-10-21 15:30 ` Jakub Kicinski
2022-10-25 2:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Xin Long @ 2022-10-21 14:22 UTC (permalink / raw)
To: network dev; +Cc: davem, kuba, Eric Dumazet, Paolo Abeni, Vladyslav Tarasiuk
The similar fix as commit 46cdedf2a0fa ("ethtool: pse-pd: fix null-deref on
genl_info in dump") is also needed for ethtool eeprom.
Fixes: c781ff12a2f3 ("ethtool: Allow network drivers to dump arbitrary EEPROM data")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
net/ethtool/eeprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ethtool/eeprom.c b/net/ethtool/eeprom.c
index 1c94bb8ea03f..49c0a2a77f02 100644
--- a/net/ethtool/eeprom.c
+++ b/net/ethtool/eeprom.c
@@ -124,7 +124,7 @@ static int eeprom_prepare_data(const struct ethnl_req_info *req_base,
if (ret)
goto err_free;
- ret = get_module_eeprom_by_page(dev, &page_data, info->extack);
+ ret = get_module_eeprom_by_page(dev, &page_data, info ? info->extack : NULL);
if (ret < 0)
goto err_ops;
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] ethtool: eeprom: fix null-deref on genl_info in dump
2022-10-21 14:22 [PATCH net] ethtool: eeprom: fix null-deref on genl_info in dump Xin Long
@ 2022-10-21 15:30 ` Jakub Kicinski
2022-10-25 2:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2022-10-21 15:30 UTC (permalink / raw)
To: Xin Long
Cc: network dev, davem, Eric Dumazet, Paolo Abeni, Vladyslav Tarasiuk
On Fri, 21 Oct 2022 10:22:47 -0400 Xin Long wrote:
> The similar fix as commit 46cdedf2a0fa ("ethtool: pse-pd: fix null-deref on
> genl_info in dump") is also needed for ethtool eeprom.
>
> Fixes: c781ff12a2f3 ("ethtool: Allow network drivers to dump arbitrary EEPROM data")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] ethtool: eeprom: fix null-deref on genl_info in dump
2022-10-21 14:22 [PATCH net] ethtool: eeprom: fix null-deref on genl_info in dump Xin Long
2022-10-21 15:30 ` Jakub Kicinski
@ 2022-10-25 2:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-10-25 2:20 UTC (permalink / raw)
To: Xin Long; +Cc: netdev, davem, kuba, edumazet, pabeni, vladyslavt
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 21 Oct 2022 10:22:47 -0400 you wrote:
> The similar fix as commit 46cdedf2a0fa ("ethtool: pse-pd: fix null-deref on
> genl_info in dump") is also needed for ethtool eeprom.
>
> Fixes: c781ff12a2f3 ("ethtool: Allow network drivers to dump arbitrary EEPROM data")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
> net/ethtool/eeprom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net] ethtool: eeprom: fix null-deref on genl_info in dump
https://git.kernel.org/netdev/net/c/9d9effca9d7d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-25 2:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-21 14:22 [PATCH net] ethtool: eeprom: fix null-deref on genl_info in dump Xin Long
2022-10-21 15:30 ` Jakub Kicinski
2022-10-25 2:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).