From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22D30C3A59D for ; Mon, 24 Oct 2022 06:14:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230433AbiJXGOm (ORCPT ); Mon, 24 Oct 2022 02:14:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230324AbiJXGNt (ORCPT ); Mon, 24 Oct 2022 02:13:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3529D5F7E4 for ; Sun, 23 Oct 2022 23:13:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5DDB261011 for ; Mon, 24 Oct 2022 06:13:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B4A9C433D6; Mon, 24 Oct 2022 06:13:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666592018; bh=WPubR+9Ws5kN5Xtxg/TTUc0ewFULWqYNy4mi2Jha8E4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ToV1wmpzieULtq2XdMZiIHzXzKXuD5c/1XJp9dbwE4bqgHPwP41vQmEAhhSrguyfz Rx+jmFJFmcYfRTsnIIdJ7sVstHqHmtJ1wVe2scKaNBrBeXPEXAbKpdKE/i/QMhcLS0 sKNHFqRIlaYezTi+NCaXXut2bkYRKgVMaWxzGtpNQtoybIBpaMiMUJ77a1DmEGwLcz tuddS/WJp/xlTPdIAQuu90k/qPAr3EthyFw1K2EfQoizyMdNkejn5oO+jCxO+/nBHm vMZniaef6x85jhLBN/JDM2tWt7ForYKm+JORaiQUl1vQFJjtRlai1rbuhL7kto40wn NNN7XAPKbf+ng== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Raed Salem , Lior Nahmanson Subject: [V2 net 13/16] net/mlx5e: Fix macsec coverity issue at rx sa update Date: Mon, 24 Oct 2022 07:12:17 +0100 Message-Id: <20221024061220.81662-14-saeed@kernel.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221024061220.81662-1-saeed@kernel.org> References: <20221024061220.81662-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Raed Salem The cited commit at update rx sa operation passes object attributes to MACsec object create function without initializing/setting all attributes fields leaving some of them with garbage values, therefore violating the implicit assumption at create object function, which assumes that all input object attributes fields are set. Fix by initializing the object attributes struct to zero, thus leaving unset fields with the legal zero value. Fixes: aae3454e4d4c ("net/mlx5e: Add MACsec offload Rx command support") Signed-off-by: Raed Salem Reviewed-by: Lior Nahmanson Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c index 41970067917b..d111e86afe72 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c @@ -432,7 +432,7 @@ static int mlx5e_macsec_update_rx_sa(struct mlx5e_macsec *macsec, bool active) { struct mlx5_core_dev *mdev = macsec->mdev; - struct mlx5_macsec_obj_attrs attrs; + struct mlx5_macsec_obj_attrs attrs = {}; int err = 0; if (rx_sa->active != active) -- 2.37.3