From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEE90C38A2D for ; Mon, 24 Oct 2022 15:26:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230107AbiJXP0R (ORCPT ); Mon, 24 Oct 2022 11:26:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230288AbiJXP0A (ORCPT ); Mon, 24 Oct 2022 11:26:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F4FFD38F1 for ; Mon, 24 Oct 2022 07:11:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4439661280 for ; Mon, 24 Oct 2022 14:00:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42DC0C433C1; Mon, 24 Oct 2022 14:00:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666620011; bh=pUIJr3od4lzsGcng9IWY+FNxYIrvxUgzQ3l80dlLSoI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V66J4VwQsHD88HlTwn3HvbskmlxdkpsFU03QdY/iVq5exjGd9H3hiql/G+54WFNkR 4nCn0hdCzs12esOcg1GXHUmOV4O/kAIizZzaQtcfYxVhhgF/W9Cp/tnk58+iW8NK+X DjQ0urLmBy5ttKel29A3uT6b2wZWkKW286n+AwVXhWOErtG3BrT9qAU4nvTlQK1GJv Ueu8QuTKP7O5Uvw7naQ993WmTC7HjC41DRt7p2TCCyida4vpvmedFv0naxVGSoS+vr pszNLNJkmLgQXCSqpH1AmqbqVTbN/exogoOWS3nk251TioSihiAssPsA86Oa27B+mX 5Z2wtWALxFeuw== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Yevgeny Kliteynik , Chris Mi , Alex Vesker Subject: [net-next 01/14] net/mlx5: DR, In destroy flow, free resources even if FW command failed Date: Mon, 24 Oct 2022 14:57:21 +0100 Message-Id: <20221024135734.69673-2-saeed@kernel.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221024135734.69673-1-saeed@kernel.org> References: <20221024135734.69673-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yevgeny Kliteynik Otherwise resources will never be freed and refcount will not be decreased. Signed-off-by: Chris Mi Signed-off-by: Yevgeny Kliteynik Reviewed-by: Alex Vesker Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/steering/dr_table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_table.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_table.c index 31d443dd8386..eb81759244d5 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_table.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_table.c @@ -292,7 +292,7 @@ int mlx5dr_table_destroy(struct mlx5dr_table *tbl) mlx5dr_dbg_tbl_del(tbl); ret = dr_table_destroy_sw_owned_tbl(tbl); if (ret) - return ret; + mlx5dr_err(tbl->dmn, "Failed to destoy sw owned table\n"); dr_table_uninit(tbl); -- 2.37.3