From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>, Arnd Bergmann <arnd@kernel.org>
Cc: Liang He <windhl@126.com>,
davem@davemloft.net, pabeni@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH] appletalk: Fix potential refcount leak
Date: Mon, 24 Oct 2022 14:50:48 -0700 [thread overview]
Message-ID: <20221024145048.2b679a59@kernel.org> (raw)
In-Reply-To: <CANn89iL==crwYiOpcgx=zVG1porMpMt23RCp=_JGpQmxOwK04w@mail.gmail.com>
On Mon, 24 Oct 2022 08:36:13 -0700 Eric Dumazet wrote:
> IMO appletalk is probably completely broken.
>
> atalk_routes_lock is not held while other threads might use rt->dev
> and would not expect rt->dev to be changed under them
> (atalk_route_packet() )
>
> I would vote to remove it completely, unless someone is willing to
> test any change in it.
+1 for killing all of appletalk.
Arnd, I think you suggested the removal in the past as well, or were
you just saying to remove localtalk ?
next prev parent reply other threads:[~2022-10-24 23:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 14:47 [PATCH] appletalk: Fix potential refcount leak Liang He
2022-10-24 15:36 ` Eric Dumazet
2022-10-24 21:50 ` Jakub Kicinski [this message]
2022-10-25 7:15 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221024145048.2b679a59@kernel.org \
--to=kuba@kernel.org \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).