From: Jakub Kicinski <kuba@kernel.org>
To: Junxiao Chang <junxiao.chang@intel.com>
Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, mcoquelin.stm32@gmail.com,
Joao.Pinto@synopsys.com, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: stmmac: fix unsafe MTL DMA macro
Date: Mon, 24 Oct 2022 21:00:19 -0700 [thread overview]
Message-ID: <20221024210019.551e64ae@kernel.org> (raw)
In-Reply-To: <20221021114711.1610797-1-junxiao.chang@intel.com>
On Fri, 21 Oct 2022 19:47:10 +0800 Junxiao Chang wrote:
> Macro like "#define abc(x) (x, x)" is unsafe which might introduce
> side effects. Each MTL RxQ DMA channel mask is 4 bits, so using
> (0xf << chan) instead of GENMASK(x + 3, x) to avoid unsafe macro.
>
> Fixes: d43042f4da3e ("net: stmmac: mapping mtl rx to dma channel")
You need to point out an existing usage where this is causing problems,
otherwise this is not a fix.
And squash the two patches together, it's going to be easier to review.
next prev parent reply other threads:[~2022-10-25 4:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 11:47 [PATCH net-next 1/2] net: stmmac: fix unsafe MTL DMA macro Junxiao Chang
2022-10-21 11:47 ` [PATCH net-next 2/2] net: stmmac: remove duplicate dma queue channel macros Junxiao Chang
2022-10-25 4:00 ` Jakub Kicinski [this message]
2022-10-25 4:58 ` [PATCH net-next 1/2] net: stmmac: fix unsafe MTL DMA macro Chang, Junxiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221024210019.551e64ae@kernel.org \
--to=kuba@kernel.org \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=junxiao.chang@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).