From: Jakub Kicinski <kuba@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>
Subject: Re: [PATCH net-next 2/2] net: natsemi: xtsonic: use pr_err()
Date: Mon, 24 Oct 2022 21:12:50 -0700 [thread overview]
Message-ID: <20221024211250.2807f137@kernel.org> (raw)
In-Reply-To: <20221025031236.1031330-2-yangyingliang@huawei.com>
On Tue, 25 Oct 2022 11:12:36 +0800 Yang Yingliang wrote:
> Use pr_err() instead of printk(KERN_ERR ...).
To what gain? Please don't pointlessly futz with old code.
next prev parent reply other threads:[~2022-10-25 4:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 3:12 [PATCH net-next 1/2] net: natsemi: xtsonic: switch to use platform_get_irq() Yang Yingliang
2022-10-25 3:12 ` [PATCH net-next 2/2] net: natsemi: xtsonic: use pr_err() Yang Yingliang
2022-10-25 4:12 ` Jakub Kicinski [this message]
2022-10-25 4:11 ` [PATCH net-next 1/2] net: natsemi: xtsonic: switch to use platform_get_irq() Jakub Kicinski
2022-10-25 8:32 ` Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221024211250.2807f137@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).