From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81818ECDFA1 for ; Tue, 25 Oct 2022 11:15:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231144AbiJYLPj (ORCPT ); Tue, 25 Oct 2022 07:15:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231809AbiJYLPe (ORCPT ); Tue, 25 Oct 2022 07:15:34 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3996C112AB3 for ; Tue, 25 Oct 2022 04:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666696531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c7bW41VuSqcRQyPX6vwXhhOS0mRKD55wff4sbYfZqKY=; b=EhKHvr6QSQqtzeu2OE2MnikX3GnrUPi3DywYMceMpH2UgsxvafHozobeElT3TymSCBOhFH ZGux/STskRcHZ3vwc+O8ybkPE8jbjMg9RJ3B4qtoIRYLRlLonG9sitFw3GxxivQQ1wWNC7 iUC0oQnlhNwLjPykJh/m2QgmUeTJUWE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-502-Hz1rVj6sN7eh-BBYncbQKw-1; Tue, 25 Oct 2022 07:15:30 -0400 X-MC-Unique: Hz1rVj6sN7eh-BBYncbQKw-1 Received: by mail-wr1-f72.google.com with SMTP id o13-20020adfa10d000000b00232c00377a0so4497937wro.13 for ; Tue, 25 Oct 2022 04:15:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c7bW41VuSqcRQyPX6vwXhhOS0mRKD55wff4sbYfZqKY=; b=hU5U8nDR+QTM/Q8Hg71LY70wUD7QkSKXSdOO1GrKkcfjZnZmHhK5X6eCvRjNa3LskF 3OLR3c0cGlGPN8d+WH3I7JBO9/67H+zGmsxdXMfDZbbUWEytvuF02/28tzADEjwT9YvG 4yGzG05frNOLwj4qPiYXaJ2z0+MKUPd+nCkjqRWva0MZ/rvFzUwiOr8867fwPtvv2fOu eF3XIc0r9yWJHgwq3JXRJw0KjPF8Ekp9A4L6Y657H+d8W+lguQwp9+K4A3dHxlsyy6dr r/o1v8Cj6L0oUb1hPvcy/s88Vd059cMSMMJdzMXarojAysSHPZlSfUCI0ARjpDG6PDD5 jDHA== X-Gm-Message-State: ACrzQf1jtpOVM1msmLYeRzI4bWiaC3RHT1RSqDJqMKGDNIGarij/Qs7J Nfcpahqke+/YLTJ8KlDcm5JZQxXDCMk3nllHjRA+MS03GzgFh5lx2arFM+jRgFTehAuifErCnL5 uN/rU4WfgggNbTYyf X-Received: by 2002:a05:600c:46cd:b0:3c6:f5ab:d383 with SMTP id q13-20020a05600c46cd00b003c6f5abd383mr26287903wmo.40.1666696528962; Tue, 25 Oct 2022 04:15:28 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5Wx1ArwGsu4MsWfDtyUa7mG+AF0bcGB36rI41IZOoqGCfUWShib+ZZQ/JK5sHXOh0g8Ltllg== X-Received: by 2002:a05:600c:46cd:b0:3c6:f5ab:d383 with SMTP id q13-20020a05600c46cd00b003c6f5abd383mr26287888wmo.40.1666696528691; Tue, 25 Oct 2022 04:15:28 -0700 (PDT) Received: from localhost.localdomain (wifi-guest-gw.tecnico.ulisboa.pt. [193.136.152.65]) by smtp.gmail.com with ESMTPSA id h6-20020a05600c314600b003c6f426467fsm11303922wmo.40.2022.10.25.04.15.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 04:15:28 -0700 (PDT) Date: Tue, 25 Oct 2022 13:15:25 +0200 From: Guillaume Nault To: Trond Myklebust Cc: Christoph Hellwig , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , linux-nfs@vger.kernel.org, Paolo Abeni , Benjamin Coddington , netdev@vger.kernel.org, Eric Dumazet Subject: Re: [PATCH v2] sunrpc: Use GFP_NOFS to prevent use of current->task_frag. Message-ID: <20221025111525.GA4415@localhost.localdomain> References: <20221010165650.GA3456@ibm-p9z-18-fsp.mgmt.pnr.lab.eng.rdu2.redhat.com> <20221011150057.GB3606@localhost.localdomain> <20221011211433.GA13385@ibm-p9z-18-fsp.mgmt.pnr.lab.eng.rdu2.redhat.com> <20221013121834.GA3353@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221013121834.GA3353@localhost.localdomain> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Oct 13, 2022 at 02:18:37PM +0200, Guillaume Nault wrote: > Still, that looks like net-next material to me. Reverting sunrpc to use > GFP_NOFS looks better for an immediate bug fix. Could we please move forward with this patch? This bug really needs to be fixed. So please let's either revert to GFP_NOFS or actively work on a different solution.