From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E73BCFA3740 for ; Tue, 25 Oct 2022 18:29:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229995AbiJYS3s (ORCPT ); Tue, 25 Oct 2022 14:29:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbiJYS3q (ORCPT ); Tue, 25 Oct 2022 14:29:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B92CB62DD for ; Tue, 25 Oct 2022 11:29:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BE04B618FB for ; Tue, 25 Oct 2022 18:29:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E816EC433D7; Tue, 25 Oct 2022 18:29:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666722584; bh=z1jMFGp7lv7c2Hel0GXXAUuzit22uZKq/PJTF95fDng=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=q9kaOwaSo8EZhOX8dcf1Ut9Wke/spb5dPYE2dui8OfBYyq1S/UH4ZTyvPQvFAh8lo KRwYe7RWK5+yk8VQ0ohM6BfZ88DQ87xVwLlZG/Tqs1SzFGHP/m+a9W0dOfi3OF5iLg YaXi5/PAdy7yCZJdnbsbL/MrttlAjXmWkIW37sbVlk9HFjFrot7VUH5XP/xEmjFHPu ZCSkOSQV4wm6lzKUO9qbzAw/X7FphR9QaAY1mbphYIDJiRBbXydYhKRC4ZfhiYB3NE z2Y6NIFEioqyW3jeuNgzH1DJ19mjLRG5hKgT92YqNuZq3XFK+fXcdZwEfv20HGw0q8 7vLFEL8w62C8g== Date: Tue, 25 Oct 2022 11:29:43 -0700 From: Jakub Kicinski To: Yang Yingliang Cc: , , Subject: Re: [PATCH net v2] net: fealnx: fix missing pci_disable_device() Message-ID: <20221025112943.3aa9024d@kernel.org> In-Reply-To: <20221025130751.1075684-1-yangyingliang@huawei.com> References: <20221025130751.1075684-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 25 Oct 2022 21:07:51 +0800 Yang Yingliang wrote: > Add missing pci_disable_device() in error path of probe() and remove() path. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Suggested-by: Leon Romanovsky > Signed-off-by: Yang Yingliang This is pointless, I'm deleting this driver.