* [PATCH net-next] net: dp83822: Print the SOR1 strap status
@ 2022-10-25 12:01 Fabio Estevam
2022-10-25 12:25 ` Andrew Lunn
2022-10-27 11:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2022-10-25 12:01 UTC (permalink / raw)
To: kuba; +Cc: andrew, dmurphy, netdev, Fabio Estevam
During the bring-up of the Ethernet PHY, it is very useful to
see the bootstrap status information, as it can help identifying
hardware bootstrap mistakes.
Allow printing the SOR1 register, which contains the strap status
to ease the bring-up.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/net/phy/dp83822.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
index b60db8b6f477..a6f05e35d91f 100644
--- a/drivers/net/phy/dp83822.c
+++ b/drivers/net/phy/dp83822.c
@@ -524,6 +524,8 @@ static int dp83822_read_straps(struct phy_device *phydev)
if (val < 0)
return val;
+ phydev_dbg(phydev, "SOR1 strap register: 0x%04x\n", val);
+
fx_enabled = (val & DP83822_COL_STRAP_MASK) >> DP83822_COL_SHIFT;
if (fx_enabled == DP83822_STRAP_MODE2 ||
fx_enabled == DP83822_STRAP_MODE3)
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: dp83822: Print the SOR1 strap status
2022-10-25 12:01 [PATCH net-next] net: dp83822: Print the SOR1 strap status Fabio Estevam
@ 2022-10-25 12:25 ` Andrew Lunn
2022-10-27 11:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2022-10-25 12:25 UTC (permalink / raw)
To: Fabio Estevam; +Cc: kuba, dmurphy, netdev
On Tue, Oct 25, 2022 at 09:01:09AM -0300, Fabio Estevam wrote:
> During the bring-up of the Ethernet PHY, it is very useful to
> see the bootstrap status information, as it can help identifying
> hardware bootstrap mistakes.
>
> Allow printing the SOR1 register, which contains the strap status
> to ease the bring-up.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: dp83822: Print the SOR1 strap status
2022-10-25 12:01 [PATCH net-next] net: dp83822: Print the SOR1 strap status Fabio Estevam
2022-10-25 12:25 ` Andrew Lunn
@ 2022-10-27 11:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-10-27 11:00 UTC (permalink / raw)
To: Fabio Estevam; +Cc: kuba, andrew, dmurphy, netdev
Hello:
This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Tue, 25 Oct 2022 09:01:09 -0300 you wrote:
> During the bring-up of the Ethernet PHY, it is very useful to
> see the bootstrap status information, as it can help identifying
> hardware bootstrap mistakes.
>
> Allow printing the SOR1 register, which contains the strap status
> to ease the bring-up.
>
> [...]
Here is the summary with links:
- [net-next] net: dp83822: Print the SOR1 strap status
https://git.kernel.org/netdev/net-next/c/c926b4c3fa1f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-27 11:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-25 12:01 [PATCH net-next] net: dp83822: Print the SOR1 strap status Fabio Estevam
2022-10-25 12:25 ` Andrew Lunn
2022-10-27 11:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).